Skip to content

Types: abline, hline, vline#249

Merged
grantmcdermott merged 9 commits intograntmcdermott:mainfrom
vincentarelbundock:type_hline
Nov 13, 2024
Merged

Types: abline, hline, vline#249
grantmcdermott merged 9 commits intograntmcdermott:mainfrom
vincentarelbundock:type_hline

Conversation

@vincentarelbundock
Copy link
Copy Markdown
Collaborator

No description provided.

@vincentarelbundock vincentarelbundock marked this pull request as ready for review November 12, 2024 19:56
@vincentarelbundock
Copy link
Copy Markdown
Collaborator Author

library(tinyplot)

tinyplot(mpg ~ hp, data = mtcars)
tinyplot_add(type = type_vline(150))

cols = c("black", "green", "orange")
tinyplot(mpg ~ hp | factor(cyl), facet = ~ factor(cyl), data = mtcars, col = cols)
tinyplot_add(type = type_vline(
  v = c(100, 150, 200), col = cols, lty = 3, lwd = 3
))

Created on 2024-11-12 with reprex v2.1.1

@vincentarelbundock
Copy link
Copy Markdown
Collaborator Author

I feel like the whole refactor is paying off in a really big way now :)

Copy link
Copy Markdown
Owner

@grantmcdermott grantmcdermott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I didn't have time to test this locally, but just left a few minor comments.

Comment thread altdoc/quarto_website.yml
Comment thread R/type_abline.R
@grantmcdermott grantmcdermott merged commit 5224974 into grantmcdermott:main Nov 13, 2024
@grantmcdermott
Copy link
Copy Markdown
Owner

Brilliant, thanks!

I've got some pressing deadlines at work. But will try to take a look at your other PRs later today.

@vincentarelbundock vincentarelbundock deleted the type_hline branch September 9, 2025 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants