Modularize: Minor PR#214
Merged
grantmcdermott merged 5 commits intograntmcdermott:mainfrom Sep 10, 2024
Merged
Conversation
grantmcdermott
requested changes
Sep 10, 2024
Owner
grantmcdermott
left a comment
grantmcdermott
left a comment
There was a problem hiding this comment.
Very nice, thanks. One minor comment and then happy to merge.
Collaborator
Author
|
thanks for the review. should be fixed now. |
grantmcdermott
approved these changes
Sep 10, 2024
Owner
|
Not so minor in the end... thanks again for the continued efficiency gains! |
Collaborator
Author
|
no it really was minor. I just noticed that your suggestion could help us simplify something else too. This was a simple PR, but I'll take the 35 lines of code removed :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A minor PR with some more modularization/simplification:
type_*()data preparation function are now stored in a dictionary with switch-style selection.