Make WebGPU classes "nominal types" (not structural types)#11
Merged
kainino0x merged 1 commit intogpuweb:masterfrom Jan 7, 2020
kainino0x:nominal-types
Merged
Make WebGPU classes "nominal types" (not structural types)#11kainino0x merged 1 commit intogpuweb:masterfrom kainino0x:nominal-types
kainino0x merged 1 commit intogpuweb:masterfrom
kainino0x:nominal-types
Conversation
austinEng
approved these changes
Jan 7, 2020
Collaborator
austinEng
left a comment
austinEng
left a comment
There was a problem hiding this comment.
Cool, that's a nifty trick.
Btw, did you see microsoft/TypeScript#33038 is coming soon?
Collaborator
Author
|
hm, I didn't see that. Looks like it works for newtypes (which is awesome!) but that makes it clunky for nominally-typed classes. We'll see how it turns out. |
This prevents bugs like: const view: GPUTextureView = device.createTexture(desc); // no .createView() Technique: https://michalzalecki.com/nominal-typing-in-typescript/#approach-1-class-with-a-private-property
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents bugs like:
Technique:
https://michalzalecki.com/nominal-typing-in-typescript/#approach-1-class-with-a-private-property