goOffline/goOnline

[asarazan]

Supported: Android, iOS, Editor.

• The Editor Impl is way out of my comfort zone, but the copy/paste seems right.
• As mentioned previously, the underlying native impls are static, but we're exposing them as instance methods on IFirebase.

[benwulfe]

you probably dont need the firebase instance if these are statics.
But if it doesn't hurt... its not bad to keep the pattern the same.

Were you able to recompile the libs to test? It's a bit complicated as the bundle for editor/mac needs to be compiled in XCode and the same code is compiled in Visual Studio for windows/editor.

[benwulfe]

thanks for the PR! looks great overall! Looks like it just needs a sanity check test on the editor

[PimDeWitte]

@asarazan have you tested this on Android, iOS and in the editor? Should be pretty simple, if you need help in doing it, drop me a line at pimdewitte95 [[at]] gmail.com. I can show you how to build to Android and iOS if you need any help with it .

[asarazan]

Hey haven't fully tested it yet. My apologies for jumping the gun on the PR. I should be able to get it fixed up this weekend!

[asarazan]

Tested and confirmed on iOS/Android. Pim I'll follow up with you over email for Editor

[PimDeWitte]

Hi @asarazan, I don't have a windows machine and so asking @benwulfe is probably best :-) thanks for testing!