refactor: expose parsed api short name and version as fields in Service#1075
Merged
refactor: expose parsed api short name and version as fields in Service#1075
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1066.
This PR exposes parsed
apiShortNameandapiVersionas fields inService.java, since the source fields (defaultHost and protoPakkage) are both defined per-service. It also:withDefaultHost(for building GapicClass) added in fix: update sample region tag to parse host instead of proto package #1040 withwithApiShortNameandwithApiVersion. (Composers and tests where this is currently used for sample generation are updated)This change will enable Spring Codegen (when eventually split out from this repo) to reuse this parsing logic in descriptive comments and metadata. It also moves the parsing logic to earlier in the parse-compose process.