Skip to content
This repository was archived by the owner on Mar 13, 2026. It is now read-only.

fix: Index on a table containing columns with no sort order fails while reflecting the table#400

Closed
mmahmed wants to merge 1 commit intogoogleapis:mainfrom
mmahmed:index_column_order_fix
Closed

fix: Index on a table containing columns with no sort order fails while reflecting the table#400
mmahmed wants to merge 1 commit intogoogleapis:mainfrom
mmahmed:index_column_order_fix

Conversation

@mmahmed
Copy link

@mmahmed mmahmed commented Jun 11, 2024 •
edited
Loading

Fixes #399

  1. Ignore None order as SQLAlchemy only processes ASC, DESC
  2. SQLAlchemy requires order in lowercase (asc, desc)

@google-cla
Copy link

google-cla bot commented Jun 11, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Jun 11, 2024 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. label Jun 11, 2024
@mmahmed mmahmed changed the title Fixing Column Order Attributes on Index Fixing Column Order Attributes Jun 11, 2024
@mmahmed mmahmed force-pushed the index_column_order_fix branch from 2ac9816 to 9044cc8 Compare June 11, 2024 17:44
@mmahmed mmahmed changed the title Fixing Column Order Attributes fix: Index on a table containing columns with no sort order fails while reflecting the table Jun 11, 2024
@olavloite olavloite self-assigned this Jul 8, 2024
@olavloite
Copy link
Contributor

olavloite commented Jul 8, 2024

@mmahmed Would you mind adding a test that fails without this change and succeeds with the change?

@mmahmed
fix: Index on a table containing columns with no sort order fails whi…
f687c12 
…le reflecting the table

Fixes:
1. Ignore None order as SQLAlchemy only processes ASC, DESC
2. SQLAlchemy requires order in lowercase (asc, desc)
@mmahmed mmahmed force-pushed the index_column_order_fix branch from 9044cc8 to f687c12 Compare July 9, 2024 11:03
@olavloite olavloite mentioned this pull request Nov 4, 2024
Merged
@olavloite
Copy link
Contributor

olavloite commented Nov 4, 2024

Closing in favor of #485

@olavloite olavloite closed this Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@olavloite olavloite

Labels

api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Index on a table containing columns with no sort order fails while reflecting the table

2 participants

@mmahmed @olavloite