Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions google/cloud/ndb/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -635,14 +635,16 @@ def new_entity(key):

continue

def base_value_or_none(value):
return None if value is None else _BaseValue(value)

if not (prop is not None and isinstance(prop, Property)):
if value is not None and isinstance( # pragma: NO BRANCH
entity, Expando
):
if isinstance(value, list):
value = [
(_BaseValue(sub_value) if sub_value else None)
for sub_value in value
base_value_or_none(sub_value) for sub_value in value
]
else:
value = _BaseValue(value)
Expand All @@ -656,8 +658,7 @@ def new_entity(key):
if isinstance(value, list):
# Not a projection
value = [
(_BaseValue(sub_value) if sub_value else None)
for sub_value in value
base_value_or_none(sub_value) for sub_value in value
]
else:
# Projection
Expand Down
18 changes: 18 additions & 0 deletions tests/system/test_crud.py
Original file line number Diff line number Diff line change
Expand Up @@ -1095,3 +1095,21 @@ def user_id(self):
retreived = key.get()
assert retreived.user.email() == "somebody@example.com"
assert retreived.user.auth_domain() == "gmail.com"


@pytest.mark.usefixtures("client_context")
def test_repeated_empty_strings(dispose_of):
"""Regression test for issue # 300.

https://github.com/googleapis/python-ndb/issues/300
"""

class SomeKind(ndb.Model):
foo = ndb.StringProperty(repeated=True)

entity = SomeKind(foo=["", ""])
key = entity.put()
dispose_of(key._key)

retreived = key.get()
assert retreived.foo == ["", ""]