This repository was archived by the owner on Mar 6, 2026. It is now read-only.
fix: Convert NDB keys to Datastore keys for serialization.#287
Merged
chrisrossi merged 1 commit intogoogleapis:masterfrom Jan 10, 2020
Merged
fix: Convert NDB keys to Datastore keys for serialization.#287chrisrossi merged 1 commit intogoogleapis:masterfrom
chrisrossi merged 1 commit intogoogleapis:masterfrom
Conversation
See comments in code for design considerations. This is a compromise solution. Fixes googleapis#284.
googlebot
added
the
cla: yes
cguardia
approved these changes
Jan 10, 2020
Contributor
cguardia
left a comment
cguardia
left a comment
There was a problem hiding this comment.
I agree that not introducing backwards incompatibilities is a good idea, given all the efforts we've done at staying mostly compatible with older versions.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See comments in code for design considerations. This is a compromise
solution.
Fixes #284.