This repository was archived by the owner on Mar 6, 2026. It is now read-only.
fix: fix missing __ne__ methods#279
Merged
cguardia merged 3 commits intogoogleapis:masterfrom Dec 31, 2019
Merged
Conversation
Removed unnecessary `_datastore_query._Result.__ne__` since `functools.total_ordering` defines it from `__eq__`. Added `key.Key.__ne__` from App Engine NDB for Python 2 compatibility. Added `model._NotEqualMixin` from App Engine NDB and used it in `model.IndexProperty`, `model.Index`, `model.IndexState`, `model._BaseValue` and `model.Model` for Python 2 compatibility. Added `query.Node.__ne__` from App Engine NDB so that it is used by all subclasses and removed unnecessary `query.FilterNode.__ne__`.
googlebot
added
the
cla: yes
cguardia
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
cguardia
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed unnecessary
_datastore_query._Result.__ne__sincefunctools.total_orderingdefines it from__eq__.Added
key.Key.__ne__from App Engine NDB for Python 2 compatibility.Added
model._NotEqualMixinfrom App Engine NDB and used it inmodel.IndexProperty,model.Index,model.IndexState,model._BaseValueandmodel.Modelfor Python 2 compatibility.Added
query.Node.__ne__from App Engine NDB so that it is used byall subclasses and removed unnecessary
query.FilterNode.__ne__.