This repository was archived by the owner on Mar 6, 2026. It is now read-only.
Implement Future.cancel()#204
Merged
chrisrossi merged 1 commit intogoogleapis:masterfrom Sep 17, 2019
Merged
Conversation
googlebot
added
the
cla: yes
This brings our implementation of ``Future`` in parity with the ``Future`` interface defined in the Python 3 standard library, and makes it possible to cancel asynchronous ``grpc`` calls from NDB.
cguardia
approved these changes
Sep 17, 2019
Contributor
cguardia
left a comment
cguardia
left a comment
There was a problem hiding this comment.
Looks very good, thanks!
chrisrossi
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings our implementation of
Futurein parity with theFutureinterface defined in the Python 3 standard library, and makesit possible to cancel asynchronous
grpccalls from NDB.