This repository was archived by the owner on Mar 6, 2026. It is now read-only.
feat: use bigquery-magics package for the %%bigquery magic#1965
Merged
Conversation
product-auto-label
bot
added
the
api: bigquery
Closed
2 tasks
chalmerlowe
approved these changes
Jul 10, 2024
Collaborator
chalmerlowe
left a comment
chalmerlowe
left a comment
There was a problem hiding this comment.
LGTM. One minor QUESTION/PREFERENCE.
Approving.
samples/magics/noxfile_config.py
Outdated
Comment on lines
+27
to
+29
| # TODO: Enable 3.10 once there is a geopandas/fiona release. | ||
| # https://github.com/Toblerity/Fiona/issues/1043 | ||
| "3.10", |
Collaborator
There was a problem hiding this comment.
QUESTION/PREFERENCE:
This issue appears to be closed. I am not clear on what release we need to see from Fiona. This issue was closed on Nov 21, 2021.
They currently claim to require 3.8 and above.
If it is not an issue, I recommend we remove this statement.
Suggested change
| # TODO: Enable 3.10 once there is a geopandas/fiona release. | |
| # https://github.com/Toblerity/Fiona/issues/1043 | |
| "3.10", |
Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
This was referenced Oct 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates version of
%%bigquerymagic in this package.Note: I keep the implementation intact to reduce disruption for folks that don't install the
ipythonextras.Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes googleapis/python-bigquery-magics#14
🦕