fix: github workflow vulnerable to script injection#3232
Merged
rahul2393 merged 2 commits intogoogleapis:mainfrom Aug 22, 2024
Merged
fix: github workflow vulnerable to script injection#3232rahul2393 merged 2 commits intogoogleapis:mainfrom
rahul2393 merged 2 commits intogoogleapis:mainfrom
Conversation
Signed-off-by: Diogo Teles Sant'Anna <diogoteles@google.com>
product-auto-label
bot
added
size: xs
rahul2393
approved these changes
Aug 6, 2024
rahul2393
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Contributor
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green
bot
removed
the
automerge
Contributor
Author
|
Hey @rahul2393, seems like the auto merge didn't happen because one of the test failed. Should I do anything about it? |
product-auto-label
bot
added
size: s
harshachinta
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
lqiu96
pushed a commit
that referenced
this pull request
Sep 10, 2024
* fix: github workflow vulnerable to script injection Signed-off-by: Diogo Teles Sant'Anna <diogoteles@google.com> * inline repo's full_name as env var --------- Signed-off-by: Diogo Teles Sant'Anna <diogoteles@google.com> Co-authored-by: Diego Marquez <diegomarquezp@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I'm Diogo from Google's Open Source Security Team(GOSST) and I'm dropping by to suggest this small change that will enhance the security of your repository by preventing script injection attacks through your GitHub workflows.
In the piece of code I changed, you were directly using the value of a variable that comes from a user's input, so a malicious user could exploit that input and use it to run arbitrary code. By using an intermediate environment variable, the value of the expression is stored in memory, used as a variable and doesn't interact with the script generation process. This mitigates the script injection risks and also keeps your workflow running exactly as before.
You can find more information about this on this github documentation or in this gitguardian blogpost.
Cheers!