Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

feat: add support for CallCredentials#26

Merged
olavloite merged 2 commits intomasterfrom
call-credentials
Jan 14, 2020
Merged

feat: add support for CallCredentials#26
olavloite merged 2 commits intomasterfrom
call-credentials

Conversation

@olavloite
Copy link
Copy Markdown
Collaborator

Adds support for using CallCredentials that could vary per call instead of only static credentials passed in at startup.

Fixes #18

Adds support for using CallCredentials that could vary per call
instead of only static credentials passed in at startup.

Fixes #18
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 10, 2020
@olavloite olavloite added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jan 13, 2020
@Capstan
Copy link
Copy Markdown

Capstan commented Jan 13, 2020

LGTM. I believe this would work for our purposes.

Copy link
Copy Markdown
Contributor

@hengfengli hengfengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 👍

@olavloite olavloite merged commit 1112357 into master Jan 14, 2020
@olavloite olavloite deleted the call-credentials branch January 14, 2020 08:44
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How do I apply a io.grpc.CallCredentials to ServiceOptions?

4 participants