Skip to content

Spanner: Adjust gRPC timeouts (via synth). #8445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crwilcox merged 1 commit into from
Jun 21, 2019
+12 −12
Merged

Spanner: Adjust gRPC timeouts (via synth). #8445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions spanner/google/cloud/spanner_admin_database_v1/gapic/database_admin_client_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"retry_params_name": "default",
},
"CreateDatabase": {
"timeout_millis": 30000,
"timeout_millis": 3600000,
Copy link
Copy Markdown
Contributor

@tseaver tseaver Jun 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crwilcox, @snehashah16 Are we actually going to have users wait for an hour before raising en error?

Copy link
Copy Markdown
Contributor

@crwilcox crwilcox Jun 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. There is an error in the LRO that blocks instead of returning. This is really the safest option at this time. :(

"retry_codes_name": "non_idempotent",
"retry_params_name": "default",
},
Expand All @@ -33,12 +33,12 @@
"retry_params_name": "default",
},
"UpdateDatabaseDdl": {
"timeout_millis": 30000,
"timeout_millis": 3600000,
"retry_codes_name": "idempotent",
"retry_params_name": "default",
},
"DropDatabase": {
"timeout_millis": 30000,
"timeout_millis": 3600000,
"retry_codes_name": "idempotent",
"retry_params_name": "default",
},
Expand Down
8 changes: 4 additions & 4 deletions spanner/google/cloud/spanner_v1/gapic/spanner_client_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
},
"retry_params": {
"default": {
"initial_retry_delay_millis": 1000,
"initial_retry_delay_millis": 250,
"retry_delay_multiplier": 1.3,
"max_retry_delay_millis": 32000,
"initial_rpc_timeout_millis": 60000,
Expand All @@ -17,7 +17,7 @@
"total_timeout_millis": 600000,
},
"streaming": {
"initial_retry_delay_millis": 1000,
"initial_retry_delay_millis": 250,
"retry_delay_multiplier": 1.3,
"max_retry_delay_millis": 32000,
"initial_rpc_timeout_millis": 120000,
Expand All @@ -26,7 +26,7 @@
"total_timeout_millis": 1200000,
},
"long_running": {
"initial_retry_delay_millis": 1000,
"initial_retry_delay_millis": 250,
"retry_delay_multiplier": 1.3,
"max_retry_delay_millis": 32000,
"initial_rpc_timeout_millis": 3600000,
Expand All @@ -47,7 +47,7 @@
"retry_params_name": "default",
},
"ListSessions": {
"timeout_millis": 30000,
"timeout_millis": 3600000,
"retry_codes_name": "idempotent",
"retry_params_name": "default",
},
Expand Down
10 changes: 5 additions & 5 deletions spanner/synth.metadata
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
{
"updateTime": "2019-06-18T12:28:09.750898Z",
"updateTime": "2019-06-20T12:28:03.852119Z",
"sources": [
{
"generator": {
"name": "artman",
"version": "0.27.0",
"dockerImage": "googleapis/artman@sha256:b036a7f4278d9deb5796f065e5c7f608d47d75369985ca7ab5039998120e972d"
"version": "0.29.0",
"dockerImage": "googleapis/artman@sha256:b79c8c20ee51e5302686c9d1294672d59290df1489be93749ef17d0172cc508d"
}
},
{
"git": {
"name": "googleapis",
"remote": "https://github.com/googleapis/googleapis.git",
"sha": "384aa843867c4d17756d14a01f047b6368494d32",
"internalRef": "253675319"
"sha": "45e125f9e30dc5d45b52752b3ab78dd4f6084f2d",
"internalRef": "254026509"
}
},
{
Expand Down