Spanner: rationalize 'all_types' round-trip systest#6379
Merged
tseaver merged 3 commits intogoogleapis:masterfrom Nov 9, 2018
tseaver:spanner-rationalize-all_types-systests
Merged
Spanner: rationalize 'all_types' round-trip systest#6379tseaver merged 3 commits intogoogleapis:masterfrom tseaver:spanner-rationalize-all_types-systests
tseaver merged 3 commits intogoogleapis:masterfrom
tseaver:spanner-rationalize-all_types-systests
Conversation
Use a separate 'pkey' column for the key, to make clear how null integer values are normally used.
Add tableless tests for float bindings with transfinite values. Add tableless tests for queries returning explicit transfinite values.
googlebot
added
the
cla: yes
Contributor
Author
|
@crwilcox PTAL |
Contributor
Author
|
Testing-only change. Even if further work is needed for tagging, this makes the round-trip intent so much clearer that it is a no-brainer. |
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
* Expand 'all_types' table to include arrays of all types. Use a separate 'pkey' column for the key, to make clear how null integer values are normally used. * Remove redundant query param bindings tests using 'all_types' table. Add tableless tests for float bindings with transfinite values. Add tableless tests for queries returning explicit transfinite values. * Refactor round-trip test, 'all_types' data to make feature coverage clearar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
all_typestable to include arrays of all types.all_typestable.all_typesdata to make feature coverage obvious (null values, non-null values, empty arrays, non-empty arrays w/ mixed non-null and null items).