Spanner: Read multiple keys with index by chemelnucfin · Pull Request #4386 · googleapis/google-cloud-python

chemelnucfin · 2017-11-13T01:16:39Z

reads multiple keys using index

dhermes · 2017-11-13T16:52:37Z

@chemelnucfin Don't forget to add relevant labels to PRs as well as issues

spanner/tests/system/test_system.py

+    def test_read_with_multiple_keys_index(self):
+        ROW_COUNT = 10
+        EXTRA_DDL = ['CREATE INDEX name ON contacts(first_name, last_name)']
+        MY_COLUMNS = self.COLUMNS[1], self.COLUMNS[2]


spanner/tests/system/test_system.py

+        pool = BurstyPool()
+
+        temp_db = Config.INSTANCE.database(
+            'test_read_multi_keys_index', ddl_statements=DDL_STATEMENTS + EXTRA_DDL,


spanner/tests/system/test_system.py

+        pool = BurstyPool()
+
+        temp_db = Config.INSTANCE.database(
+            'test_read_multi_keys_index', ddl_statements=DDL_STATEMENTS + EXTRA_DDL,


spanner/tests/system/test_system.py

+        self.to_delete.append(session)
+        expected = list(
+            [[row[1], row[2]] for
+                index, row in enumerate(self._row_data(ROW_COUNT))])


spanner/tests/system/test_system.py

+            [[row[1], row[2]] for
+                index, row in enumerate(self._row_data(ROW_COUNT))])
+        keyset = [(expected[index][0], expected[index][1]) for
+                      index in range(len(expected))]


spanner/tests/system/test_system.py

+                                 MY_COLUMNS,
+                                 KeySet(keys=keyset),
+                                 index='name'))
+        temp_db.drop()


tseaver · 2017-11-13T17:41:19Z

Ugh, @chemelnucfin my review comments predated your force push. They are still probably valid.

spanner/tests/system/test_system.py

+        if not temp_db.exists(): # prevent Conflicts 
+            operation = temp_db.create()
+            self.to_delete.append(_DatabaseDropper(temp_db))
+            operation.result(90)


spanner/tests/system/test_system.py

+        expected = list(
+            [[row[1], row[2]] for
+            index, row in enumerate(self._row_data(ROW_COUNT))]
+        )


spanner/tests/system/test_system.py

+        keyset = [
+            (expected[index][0], expected[index][1]) for
+            index in range(len(expected))
+        ]


spanner/tests/system/test_system.py

+                                 KeySet(keys=keyset),
+                                 index='name')
+        )
+        temp_db.drop()


chemelnucfin · 2017-11-14T23:53:54Z

@tseaver PTAL, thanks.

spanner/tests/system/test_system.py

+        ddl_create = ['CREATE INDEX name ON contacts(first_name, last_name)']
+        columns = self.COLUMNS[1], self.COLUMNS[2]
+        try:
+            operation = self._db.update_ddl(ddl_create)


spanner/tests/system/test_system.py

+            session, committed = self._set_up_table(row_count, db=self._db)
+            self.to_delete.append(session)
+            expected = [[row[1], row[2]] for row in self._row_data(row_count)]
+            keyset = [(row[0], row[1]) for row in expected]


chemelnucfin · 2017-12-05T01:13:16Z

@tseaver PTAL, thanks.

chemelnucfin requested a review from lukesneeringer as a code owner November 13, 2017 01:16

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 13, 2017

chemelnucfin force-pushed the issue4364-read_index_with_single_key branch 3 times, most recently from 0d0299e to 177df9c Compare November 13, 2017 16:07

dhermes added the api: spanner Issues related to the Spanner API. label Nov 13, 2017

dhermes reviewed Nov 13, 2017

View reviewed changes

chemelnucfin changed the title ~~read multiple keys with index~~ Spanner: read multiple keys with index Nov 13, 2017

chemelnucfin force-pushed the issue4364-read_index_with_single_key branch from 177df9c to a9bd0cc Compare November 13, 2017 17:26

tseaver suggested changes Nov 13, 2017

View reviewed changes

chemelnucfin force-pushed the issue4364-read_index_with_single_key branch from a9bd0cc to c1f7d3c Compare November 14, 2017 23:32

tseaver reviewed Nov 15, 2017

View reviewed changes

chemelnucfin mentioned this pull request Nov 16, 2017

Spanner: Read single key with index #4403

Merged

chemelnucfin changed the title ~~Spanner: read multiple keys with index~~ Spanner: Read multiple keys with index Nov 18, 2017

chemelnucfin force-pushed the issue4364-read_index_with_single_key branch 4 times, most recently from 060e73d to 7b931ff Compare December 5, 2017 00:33

read multiple keys with index

2ea8daa

chemelnucfin force-pushed the issue4364-read_index_with_single_key branch from 7b931ff to 2ea8daa Compare December 5, 2017 00:33

tseaver approved these changes Dec 5, 2017

View reviewed changes

chemelnucfin merged commit 3fb9f16 into googleapis:master Dec 5, 2017

parthea pushed a commit that referenced this pull request Mar 9, 2026

read multiple keys with index (#4386)

d0809f9

Conversation

chemelnucfin commented Nov 13, 2017

Uh oh!

dhermes commented Nov 13, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

tseaver commented Nov 13, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

chemelnucfin commented Nov 14, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

chemelnucfin commented Dec 5, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants