fix: include amended user agent in read client#17592
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request reorganizes imports across several files and updates the _ensure_bqstorage_client method in client.py to append pandas-gbq version information to the client_info user agent when initializing the BigQueryReadClient. It also adds comprehensive unit tests to verify this behavior under different scenarios. The review feedback suggests adding a # type: ignore[assignment] comment to the fallback assignment pandas_gbq = None to prevent potential mypy type-checking errors.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
parthea
reviewed
Jun 30, 2026
Contributor
|
Switching to draft until presubmits are green |
tswast
commented
Jul 1, 2026
shuoweil
approved these changes
Jul 1, 2026
g-husam
pushed a commit
that referenced
this pull request
Jul 1, 2026
Towards internal issue b/526614511 🦕 --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards internal issue b/526614511 🦕