chore: librarian generate pull request: 20260311T095333Z#16067
Merged
Conversation
Contributor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is an automated update to the Cloud Client Libraries for Compute Engine v1 API. It incorporates recent changes from upstream protocol buffer definitions, introducing new API services for managing composite health checks and health sources, and extending existing services with new aggregated listing and version retrieval functionalities. The update ensures the client library remains synchronized with the latest API capabilities. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is an automated update from the Librarian CLI, adding new services and types for the Compute Engine v1 API. The changes primarily involve adding new files for RegionCompositeHealthChecks and RegionHealthSources services, and updating existing files to integrate them. My review focuses on the maintainability of the generated code, specifically the alphabetical sorting of imports and __all__ lists in several __init__.py files, which should be addressed to improve code clarity and reduce future merge conflicts.
Comment on lines
898
to
912
| HealthCheckReference, | ||
| HealthChecksAggregatedList, | ||
| HealthCheckService, | ||
| HealthCheckServiceAggregatedList, | ||
| HealthCheckServiceReference, | ||
| HealthCheckServicesList, | ||
| HealthCheckServicesScopedList, | ||
| HealthChecksScopedList, | ||
| HealthSource, | ||
| HealthSourceAggregatedList, | ||
| HealthSourceList, | ||
| HealthSourcesScopedList, | ||
| HealthStatus, | ||
| HealthStatusForNetworkEndpoint, | ||
| Help, |
Contributor
There was a problem hiding this comment.
The list of imported symbols in this block is not alphabetically sorted. For better maintainability and to avoid merge conflicts, please sort these lists. For example, HealthCheckService should come before HealthChecksAggregatedList.
Suggested change
| HealthCheckReference, | |
| HealthChecksAggregatedList, | |
| HealthCheckService, | |
| HealthCheckServiceAggregatedList, | |
| HealthCheckServiceReference, | |
| HealthCheckServicesList, | |
| HealthCheckServicesScopedList, | |
| HealthChecksScopedList, | |
| HealthSource, | |
| HealthSourceAggregatedList, | |
| HealthSourceList, | |
| HealthSourcesScopedList, | |
| HealthStatus, | |
| HealthStatusForNetworkEndpoint, | |
| Help, | |
| HealthCheckReference, | |
| HealthCheckService, | |
| HealthCheckServiceAggregatedList, | |
| HealthCheckServiceReference, | |
| HealthCheckServicesList, | |
| HealthCheckServicesScopedList, | |
| HealthChecksAggregatedList, | |
| HealthChecksScopedList, | |
| HealthSource, | |
| HealthSourceAggregatedList, | |
| HealthSourceList, | |
| HealthSourcesScopedList, | |
| HealthStatus, | |
| HealthStatusForNetworkEndpoint, | |
| Help, |
Comment on lines
2883
to
2897
| "HealthCheckReference", | ||
| "HealthChecksAggregatedList", | ||
| "HealthCheckService", | ||
| "HealthCheckServiceAggregatedList", | ||
| "HealthCheckServiceReference", | ||
| "HealthCheckServicesList", | ||
| "HealthCheckServicesScopedList", | ||
| "HealthChecksScopedList", | ||
| "HealthSource", | ||
| "HealthSourceAggregatedList", | ||
| "HealthSourceList", | ||
| "HealthSourcesScopedList", | ||
| "HealthStatus", | ||
| "HealthStatusForNetworkEndpoint", | ||
| "Help", |
Contributor
There was a problem hiding this comment.
The __all__ list in this block is not alphabetically sorted. For better maintainability and to avoid merge conflicts, please sort these lists. For example, "HealthCheckService" should come before "HealthChecksAggregatedList".
Suggested change
| "HealthCheckReference", | |
| "HealthChecksAggregatedList", | |
| "HealthCheckService", | |
| "HealthCheckServiceAggregatedList", | |
| "HealthCheckServiceReference", | |
| "HealthCheckServicesList", | |
| "HealthCheckServicesScopedList", | |
| "HealthChecksScopedList", | |
| "HealthSource", | |
| "HealthSourceAggregatedList", | |
| "HealthSourceList", | |
| "HealthSourcesScopedList", | |
| "HealthStatus", | |
| "HealthStatusForNetworkEndpoint", | |
| "Help", | |
| "HealthCheckReference", | |
| "HealthCheckService", | |
| "HealthCheckServiceAggregatedList", | |
| "HealthCheckServiceReference", | |
| "HealthCheckServicesList", | |
| "HealthCheckServicesScopedList", | |
| "HealthChecksAggregatedList", | |
| "HealthChecksScopedList", | |
| "HealthSource", | |
| "HealthSourceAggregatedList", | |
| "HealthSourceList", | |
| "HealthSourcesScopedList", | |
| "HealthStatus", | |
| "HealthStatusForNetworkEndpoint", | |
| "Help", |
Comment on lines
91
to
105
| from .services.region_autoscalers import RegionAutoscalersClient | ||
| from .services.region_backend_services import RegionBackendServicesClient | ||
| from .services.region_commitments import RegionCommitmentsClient | ||
| from .services.region_composite_health_checks import RegionCompositeHealthChecksClient | ||
| from .services.region_disk_types import RegionDiskTypesClient | ||
| from .services.region_disks import RegionDisksClient | ||
| from .services.region_health_aggregation_policies import ( | ||
| RegionHealthAggregationPoliciesClient, | ||
| ) | ||
| from .services.region_health_check_services import RegionHealthCheckServicesClient | ||
| from .services.region_health_checks import RegionHealthChecksClient | ||
| from .services.region_health_sources import RegionHealthSourcesClient | ||
| from .services.region_instance_group_managers import RegionInstanceGroupManagersClient | ||
| from .services.region_instance_groups import RegionInstanceGroupsClient | ||
| from .services.region_instance_templates import RegionInstanceTemplatesClient |
Contributor
There was a problem hiding this comment.
The list of imported clients in this block is not alphabetically sorted. For better maintainability, please sort this list. For example, RegionDisksClient should come before RegionDiskTypesClient.
Suggested change
| from .services.region_autoscalers import RegionAutoscalersClient | |
| from .services.region_backend_services import RegionBackendServicesClient | |
| from .services.region_commitments import RegionCommitmentsClient | |
| from .services.region_composite_health_checks import RegionCompositeHealthChecksClient | |
| from .services.region_disk_types import RegionDiskTypesClient | |
| from .services.region_disks import RegionDisksClient | |
| from .services.region_health_aggregation_policies import ( | |
| RegionHealthAggregationPoliciesClient, | |
| ) | |
| from .services.region_health_check_services import RegionHealthCheckServicesClient | |
| from .services.region_health_checks import RegionHealthChecksClient | |
| from .services.region_health_sources import RegionHealthSourcesClient | |
| from .services.region_instance_group_managers import RegionInstanceGroupManagersClient | |
| from .services.region_instance_groups import RegionInstanceGroupsClient | |
| from .services.region_instance_templates import RegionInstanceTemplatesClient | |
| from .services.region_autoscalers import RegionAutoscalersClient | |
| from .services.region_backend_services import RegionBackendServicesClient | |
| from .services.region_commitments import RegionCommitmentsClient | |
| from .services.region_composite_health_checks import RegionCompositeHealthChecksClient | |
| from .services.region_disks import RegionDisksClient | |
| from .services.region_disk_types import RegionDiskTypesClient | |
| from .services.region_health_aggregation_policies import ( | |
| RegionHealthAggregationPoliciesClient, | |
| ) | |
| from .services.region_health_checks import RegionHealthChecksClient | |
| from .services.region_health_check_services import RegionHealthCheckServicesClient | |
| from .services.region_health_sources import RegionHealthSourcesClient | |
| from .services.region_instance_group_managers import RegionInstanceGroupManagersClient | |
| from .services.region_instance_groups import RegionInstanceGroupsClient | |
| from .services.region_instance_templates import RegionInstanceTemplatesClient |
Comment on lines
2757
to
2773
| "HealthCheckLogConfig", | ||
| "HealthCheckReference", | ||
| "HealthCheckService", | ||
| "HealthCheckServiceAggregatedList", | ||
| "HealthCheckServiceReference", | ||
| "HealthCheckServicesList", | ||
| "HealthCheckServicesScopedList", | ||
| "HealthChecksAggregatedList", | ||
| "HealthChecksClient", | ||
| "HealthChecksScopedList", | ||
| "HealthSource", | ||
| "HealthSourceAggregatedList", | ||
| "HealthSourceList", | ||
| "HealthSourcesScopedList", | ||
| "HealthStatus", | ||
| "HealthStatusForNetworkEndpoint", | ||
| "Help", |
Contributor
There was a problem hiding this comment.
The __all__ list in this block is not alphabetically sorted. For better maintainability, please sort this list. For example, "HealthChecksClient" should come before "HealthCheckService".
Suggested change
| "HealthCheckLogConfig", | |
| "HealthCheckReference", | |
| "HealthCheckService", | |
| "HealthCheckServiceAggregatedList", | |
| "HealthCheckServiceReference", | |
| "HealthCheckServicesList", | |
| "HealthCheckServicesScopedList", | |
| "HealthChecksAggregatedList", | |
| "HealthChecksClient", | |
| "HealthChecksScopedList", | |
| "HealthSource", | |
| "HealthSourceAggregatedList", | |
| "HealthSourceList", | |
| "HealthSourcesScopedList", | |
| "HealthStatus", | |
| "HealthStatusForNetworkEndpoint", | |
| "Help", | |
| "HealthCheckLogConfig", | |
| "HealthCheckReference", | |
| "HealthChecksAggregatedList", | |
| "HealthChecksClient", | |
| "HealthChecksScopedList", | |
| "HealthCheckService", | |
| "HealthCheckServiceAggregatedList", | |
| "HealthCheckServiceReference", | |
| "HealthCheckServicesList", | |
| "HealthCheckServicesScopedList", | |
| "HealthSource", | |
| "HealthSourceAggregatedList", | |
| "HealthSourceList", | |
| "HealthSourcesScopedList", | |
| "HealthStatus", | |
| "HealthStatusForNetworkEndpoint", | |
| "Help", |
Comment on lines
632
to
646
| HealthCheckReference, | ||
| HealthChecksAggregatedList, | ||
| HealthCheckService, | ||
| HealthCheckServiceAggregatedList, | ||
| HealthCheckServiceReference, | ||
| HealthCheckServicesList, | ||
| HealthCheckServicesScopedList, | ||
| HealthChecksScopedList, | ||
| HealthSource, | ||
| HealthSourceAggregatedList, | ||
| HealthSourceList, | ||
| HealthSourcesScopedList, | ||
| HealthStatus, | ||
| HealthStatusForNetworkEndpoint, | ||
| Help, |
Contributor
There was a problem hiding this comment.
The list of imported symbols in this block is not alphabetically sorted. For better maintainability, please sort this list. For example, HealthChecksAggregatedList should come before HealthCheckService.
Suggested change
| HealthCheckReference, | |
| HealthChecksAggregatedList, | |
| HealthCheckService, | |
| HealthCheckServiceAggregatedList, | |
| HealthCheckServiceReference, | |
| HealthCheckServicesList, | |
| HealthCheckServicesScopedList, | |
| HealthChecksScopedList, | |
| HealthSource, | |
| HealthSourceAggregatedList, | |
| HealthSourceList, | |
| HealthSourcesScopedList, | |
| HealthStatus, | |
| HealthStatusForNetworkEndpoint, | |
| Help, | |
| HealthCheckReference, | |
| HealthChecksAggregatedList, | |
| HealthChecksScopedList, | |
| HealthCheckService, | |
| HealthCheckServiceAggregatedList, | |
| HealthCheckServiceReference, | |
| HealthCheckServicesList, | |
| HealthCheckServicesScopedList, | |
| HealthSource, | |
| HealthSourceAggregatedList, | |
| HealthSourceList, | |
| HealthSourcesScopedList, | |
| HealthStatus, | |
| HealthStatusForNetworkEndpoint, | |
| Help, |
ohmayr
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.
BEGIN_COMMIT
BEGIN_NESTED_COMMIT
feat: Update Compute Engine v1 API to revision 20260227 (#1166)
PiperOrigin-RevId:
Library-IDs: google-cloud-compute
Source-link: googleapis/googleapis@1c9510ae
END_NESTED_COMMIT
END_COMMIT
This pull request is generated with proto changes between
googleapis/googleapis@e8a3d842
(exclusive) and
googleapis/googleapis@1c9510ae
(inclusive).
Librarian Version: v1.0.2-0.20260309131826-42ac5c451239
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:160860d189ff1c2f7515638478823712fa5b243e27ccc33a2728669fa1e2ed0c