-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Open
Labels
type: processA process-related concern. May include testing, release, or the like.A process-related concern. May include testing, release, or the like.
Description
There is a tool to check and update the constraints files which as added in googleapis/python-test-utils#8. See the instructions in googleapis/python-test-utils#8 (comment) for information on running the tool. We could run this check on the golden files to ensure that the versions in testing/constraints-3.*.txt match the minimum version of dependencies in setup.py.
As an example.
(py39) partheniou@partheniou-vm-3:~/git/python-test-utils$ lower-bound-checker update --package-name google-auth-oauthlib --constraints-file /usr/local/google/home/partheniou/git/google-auth-library-python-oauthlib/testing/constraints-3.7.txt
(py39) partheniou@partheniou-vm-3:~/git/python-test-utils$ lower-bound-checker check --package-name google-auth-oauthlib --constraints-file /usr/local/google/home/partheniou/git/google-auth-library-python-oauthlib/testing/constraints-3.7.txt
All good!
See googleapis/synthtool#1901 for context.
The check already exists in golden files:
We just need to run the nox session here:
https://github.com/googleapis/gapic-generator-python/blob/4b7701969f8e7c3ec5f23339cf7e9ad76f0dc757/.github/workflows/tests.yaml#L322-L328
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
type: processA process-related concern. May include testing, release, or the like.A process-related concern. May include testing, release, or the like.