Skip to content

fix(spanner): resolve prelint, eslint, and prettier CI build failures #8359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sakthivelmanii merged 3 commits into from
May 27, 2026
Merged

fix(spanner): resolve prelint, eslint, and prettier CI build failures #8359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a6df97
fix(spanner): resolve prelint, eslint, and prettier CI build failures
sakthivelmanii May 26, 2026
41226ca
Merge branch 'main' into fix-spanner-lint-errors
alkatrivedi May 27, 2026
d24a0d3
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions handwritten/spanner/.eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
**/node_modules
**/coverage
test/fixtures
system-test/fixtures
build/
docs/
protos/
Expand Down
1 change: 1 addition & 0 deletions handwritten/spanner/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{
"root": true,
"extends": "./node_modules/gts"
}
2 changes: 1 addition & 1 deletion handwritten/spanner/.kokoro/system-test.sh
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion handwritten/spanner/owlbot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@

common_templates = gcp.CommonTemplates()
templates = common_templates.node_mono_repo_library(relative_dir="handwritten/spanner", source_location='build/src')
s.copy(templates, destination="handwritten/spanner", excludes=[".kokoro/samples-test.sh", ".kokoro/trampoline_v2.sh", ".github/release-trigger.yml", ".github/sync-repo-settings.yaml", "README.md"])
s.copy(templates, destination="handwritten/spanner", excludes=[".kokoro/samples-test.sh", ".kokoro/trampoline_v2.sh", ".github/release-trigger.yml", ".github/sync-repo-settings.yaml", "README.md", ".eslintignore", ".eslintrc.json"])

node.postprocess_gapic_library_hermetic(relative_dir="handwritten/spanner")

Expand Down
3 changes: 0 additions & 3 deletions handwritten/spanner/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@
"docs": "jsdoc -c .jsdoc.js",
"predocs": "npm run compile",
"lint": "gts check",
"samples-test-with-archived": "cd samples/ && npm link ../ && npm test-with-archived && cd ../",
"samples-test": "cd samples/ && npm link ../ && npm test && cd ../",
"system-test": "mocha build/system-test --timeout 1600000",
"observability-test": "mocha build/observability-test --timeout 1600000",
"cleanup": "mocha scripts/cleanup.js --timeout 30000",
Expand All @@ -52,7 +50,6 @@
"docs-test": "linkinator docs",
"predocs-test": "npm run docs",
"benchwrapper": "node bin/benchwrapper.js",
"prelint": "cd samples; npm link ../; npm install",
"precompile": "gts clean",
"compile-protos": "compileProtos src",
"coverage": "c8 mocha build/test build/test/common && c8 report --check-coverage"
Expand Down
Loading
Loading