Skip to content

fix: Upgrade the protobufjs dependency for bigquery storage #8136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danieljbruce merged 3 commits into from
Apr 29, 2026
Merged

fix: Upgrade the protobufjs dependency for bigquery storage #8136

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e0578c
Upgrade the protobuf peer dependency
danieljbruce Apr 29, 2026
6c40540
fix: Upgrade the protobufjs dependency for bigquery storage
danieljbruce Apr 29, 2026
e329275
Merge branch 'upgrade-bigquery-storage-protobufjs' of https://github.…
danieljbruce Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion handwritten/bigquery-storage/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"long": "^5.2.0"
},
"peerDependencies": {
"protobufjs": "7.2.4 - 7.5.0"
"protobufjs": "^7.5.5"

@gemini-code-assist gemini-code-assist Bot Apr 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

When updating a peerDependency range, it is important to also update the corresponding devDependency to ensure that the development environment and CI tests are running against a version that satisfies the new requirement. Since protobufjs is typically listed in devDependencies for testing purposes in this repository, please ensure that its version is also updated to ^7.5.5 to maintain consistency and avoid potential conflicts during local development or CI runs.

@danieljbruce danieljbruce Apr 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

protobufjs is not listed in dev dependencies.

},
"devDependencies": {
"@google-cloud/bigquery": "^8.0.0",
Expand Down
Loading