add Subscriber snippet by pongad · Pull Request #1613 · googleapis/google-cloud-java

pongad · 2017-02-13T07:56:01Z

The snippet is very long, but the shortest I can make it without loosing
details.

The snippet is very long, but the shortest I can make it without loosing details.

coveralls · 2017-02-13T08:11:36Z

Changes Unknown when pulling 5ee8bd3 on pongad:subscriber-snippet into ** on GoogleCloudPlatform:master**.

garrettjonesgoogle · 2017-02-13T16:48:03Z

We shouldn't need locking for a simple example - how can we simplify this?

lesv

Any tests?

Just saw Garrett's comments.

lesv · 2017-02-13T22:44:50Z

It does seem overly complex and the locks shouldn't be needed in typical usage. You really only need them if you are trying to run everything on the main thread, instead of thinking threaded and async.

...oud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/SubscriberSnippets.java

+        if (pendingReceives.decrementAndGet() != 0) {
+          return;
+        }
+        lock.lock();


coveralls · 2017-02-14T00:50:39Z

Changes Unknown when pulling 5ee8bd3 on pongad:subscriber-snippet into ** on GoogleCloudPlatform:master**.

This should be merged after #205 so that `SettableRpcFuture` could be used to address googleapis/google-cloud-java#1613

pongad · 2017-02-20T03:48:29Z

@lesv @garrettjonesgoogle PTAL. I'll add the tests for both Subscriber and Publisher in one go. They kind of belong in the same test anyway.

coveralls · 2017-02-20T04:00:35Z

Coverage decreased (-0.008%) to 81.116% when pulling 4bd5d48 on pongad:subscriber-snippet into 68ce84d on GoogleCloudPlatform:master.

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Subscriber.java

+   *     if (pendingReceives.decrementAndGet() != 0) {
+   *       return;
+   *     }
+   *     lock.lock();


pongad · 2017-02-21T04:32:38Z

@garrettjonesgoogle My mistake, PTAL

coveralls · 2017-02-21T04:43:14Z

Coverage decreased (-0.008%) to 81.116% when pulling 4f95f59 on pongad:subscriber-snippet into 68ce84d on GoogleCloudPlatform:master.

garrettjonesgoogle · 2017-02-21T04:58:55Z

LGTM with the understanding that tests will come next

pongad · 2017-02-21T23:56:32Z

@lesv PTAL

...oud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/SubscriberSnippets.java

+    });
+    subscriber.startAsync();
+
+    done.get(10, TimeUnit.MINUTES);


...oud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/SubscriberSnippets.java

+        System.out.println("got message: " + message);
+        consumer.accept(AckReply.ACK, null);
+        if (pendingReceives.decrementAndGet() == 0) {
+          done.set(null);


lesv

Let's separate support from the action of the API.

pongad · 2017-02-22T04:24:26Z

@lesv I think the updated snippets should do what you want. I think it gives us just enough room to properly test the samples too.

coveralls · 2017-02-22T09:07:46Z

Coverage decreased (-0.01%) to 81.113% when pulling 3717f02 on pongad:subscriber-snippet into 68ce84d on GoogleCloudPlatform:master.

lesv

Just add the comment. -- Thanks.

@jabubake FYI

...xamples/src/main/java/com/google/cloud/examples/pubsub/snippets/MessageReceiverSnippets.java

+    MessageReceiver receiver = new MessageReceiver() {
+      public void receiveMessage(final PubsubMessage message, final AckReplyConsumer consumer) {
+        if (blockingQueue.offer(message)) {
+          consumer.accept(AckReply.ACK, null);


pongad · 2017-02-22T23:08:24Z

@lesv Thank you for the rigorous code review. I'll wait for Travis, then merge this.

coveralls · 2017-02-23T02:06:09Z

Coverage decreased (-0.004%) to 81.113% when pulling b283ea1 on pongad:subscriber-snippet into e61ca31 on GoogleCloudPlatform:master.

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

…50.0 (#1613)

…53.0 (#1613)

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

…53.0 (#1613)

add Subscriber snippet

5ee8bd3

The snippet is very long, but the shortest I can make it without loosing details.

pongad requested review from garrettjonesgoogle and lesv February 13, 2017 07:56

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 13, 2017

lesv previously approved these changes Feb 13, 2017

View reviewed changes

lesv closed this Feb 13, 2017

lesv reopened this Feb 13, 2017

lesv reviewed Feb 14, 2017

View reviewed changes

...oud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/SubscriberSnippets.java Outdated

if (pendingReceives.decrementAndGet() != 0) {

return;

}

lock.lock();

This comment was marked as spam.

Sign in to view

pongad mentioned this pull request Feb 16, 2017

DO NOT MERGE: bump version to 0.1.1 googleapis/gax-java#207

Merged

pongad added a commit to googleapis/gax-java that referenced this pull request Feb 16, 2017

bump version to 0.1.1 (#207)

258361d

This should be merged after #205 so that `SettableRpcFuture` could be used to address googleapis/google-cloud-java#1613

pongad added 2 commits February 20, 2017 13:58

Merge branch 'master' into subscriber-snippet

9695106

pr comment

4bd5d48

garrettjonesgoogle reviewed Feb 21, 2017

View reviewed changes

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Subscriber.java Outdated

* if (pendingReceives.decrementAndGet() != 0) {

* return;

* }

* lock.lock();

This comment was marked as spam.

Sign in to view

update snippet

4f95f59

lesv reviewed Feb 22, 2017

View reviewed changes

...oud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/SubscriberSnippets.java Outdated

});

subscriber.startAsync();

done.get(10, TimeUnit.MINUTES);

This comment was marked as spam.

Sign in to view

lesv reviewed Feb 22, 2017

View reviewed changes

lesv suggested changes Feb 22, 2017

View reviewed changes

pr comment

3717f02

lesv approved these changes Feb 22, 2017

View reviewed changes

Merge branch 'master' into subscriber-snippet

b283ea1

pongad merged commit 235874d into googleapis:master Feb 22, 2017

pongad deleted the subscriber-snippet branch February 22, 2017 23:34

chingor13 pushed a commit that referenced this pull request Jan 22, 2026

chore(deps): update dependency com.google.cloud:libraries-bom to v26.…

8f32aca

…50.0 (#1613)

chingor13 pushed a commit that referenced this pull request Feb 24, 2026

chore(deps): update dependency com.google.cloud:libraries-bom to v26.…

650c303

…53.0 (#1613)

chingor13 pushed a commit that referenced this pull request Mar 12, 2026

chore(deps): update dependency com.google.cloud:libraries-bom to v26.…

df4589c

…53.0 (#1613)

Conversation

pongad commented Feb 13, 2017

Uh oh!

coveralls commented Feb 13, 2017

Uh oh!

garrettjonesgoogle commented Feb 13, 2017

Uh oh!

lesv left a comment

Choose a reason for hiding this comment

Uh oh!

lesv commented Feb 13, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Feb 14, 2017

Uh oh!

pongad commented Feb 20, 2017

Uh oh!

coveralls commented Feb 20, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

pongad commented Feb 21, 2017

Uh oh!

coveralls commented Feb 21, 2017

Uh oh!

garrettjonesgoogle commented Feb 21, 2017

Uh oh!

pongad commented Feb 21, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

lesv left a comment

Choose a reason for hiding this comment

Uh oh!

pongad commented Feb 22, 2017

Uh oh!

coveralls commented Feb 22, 2017

Uh oh!

lesv left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

pongad commented Feb 22, 2017

Uh oh!

coveralls commented Feb 23, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants