Skip to content

DO NOT MERGE: regenerating spi layer - GAX 0.0.22#1371

Closed
garrettjonesgoogle wants to merge 1 commit intogoogleapis:masterfrom
garrettjonesgoogle:master
Closed

DO NOT MERGE: regenerating spi layer - GAX 0.0.22#1371
garrettjonesgoogle wants to merge 1 commit intogoogleapis:masterfrom
garrettjonesgoogle:master

Conversation

@garrettjonesgoogle
Copy link
Member

This is a non-working PR that only includes updates to the SPI
classes. The hand-written layer still needs to be updated.

This is a non-working PR that only includes updates to the SPI
classes. The hand-written layer still needs to be updated.
@garrettjonesgoogle garrettjonesgoogle added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 4, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 4, 2016
@garrettjonesgoogle
Copy link
Member Author

/cc @shinfan @michaelbausor

@mziccard
Copy link
Contributor

mziccard commented Nov 4, 2016

@garrettjonesgoogle thanks! I started working on the integration on this changes into google-cloud-java but I realized that you removed some classes form GAX:

import com.google.api.gax.testing.DownloadableEmulatorRunner;
import com.google.api.gax.testing.GCloudEmulatorRunner;
import com.google.api.gax.testing.LocalServiceHelper;

Those classes were used in our LocalPubSubHelper (which was originally written by you and @shinfan).
I understand that you are using a mocking framework to test autogen code. However, should we add those classes back to GAX or should I implement them in google-cloud-java?

@garrettjonesgoogle
Copy link
Member Author

The auto-generated testing code already covers everything in the spi layer that the emulator test was covering, so it had become redundant from our perspective. Emulator support has been removed from our testing strategy because it doesn't scale as well. If you still want these tests in google-cloud-java to support the pubsub tests, I would recommend copying them in.

@mziccard
Copy link
Contributor

mziccard commented Nov 9, 2016

Replaced by #1379

@mziccard mziccard closed this Nov 9, 2016
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
…ncy-plugin to v3.6.0 (#1371)

* build(deps): update dependency org.apache.maven.plugins:maven-dependency-plugin to v3.6.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Jan 6, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026
…ncy-plugin to v3.6.0 (googleapis#1371)

* build(deps): update dependency org.apache.maven.plugins:maven-dependency-plugin to v3.6.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
- Removes the specific JDBC version from the samples. This is no longer needed, as the BOM now contains a JDBC driver version that is up-to-date enough to work with these samples (they require RETURN_GENERATED_KEYS).
- Adds a GitHub Actions workflow for testing the MyBatis sample.
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
🤖 I have created a release *beep* *boop*
---


## [2.13.3](https://togithub.com/googleapis/java-spanner-jdbc/compare/v2.13.2...v2.13.3) (2023-09-27)


### Dependencies

* Remove specific JDBC version from samples ([googleapis#1371](https://togithub.com/googleapis/java-spanner-jdbc/issues/1371)) ([e9af250](https://togithub.com/googleapis/java-spanner-jdbc/commit/e9af250101410fbdd43a10ce0857e1ff12a6aa6d))
* Update dependency com.google.cloud:google-cloud-spanner-bom to v6.48.0 ([googleapis#1370](https://togithub.com/googleapis/java-spanner-jdbc/issues/1370)) ([e1eee4b](https://togithub.com/googleapis/java-spanner-jdbc/commit/e1eee4be6270f55ba7090315b632984e2d226538))
* Update dependency com.spotify.fmt:fmt-maven-plugin to v2.21.1 ([googleapis#1372](https://togithub.com/googleapis/java-spanner-jdbc/issues/1372)) ([39c30d3](https://togithub.com/googleapis/java-spanner-jdbc/commit/39c30d3d54e0f279ebfe02de54bd65ddb62c675f))
* Update dependency org.springframework.boot:spring-boot-starter-parent to v3.1.4 ([googleapis#1366](https://togithub.com/googleapis/java-spanner-jdbc/issues/1366)) ([3d14db0](https://togithub.com/googleapis/java-spanner-jdbc/commit/3d14db0d359d7a5d43b328ecaf8639619032da8e))
* Update dependency org.springframework.data:spring-data-bom to v2023.0.4 ([googleapis#1367](https://togithub.com/googleapis/java-spanner-jdbc/issues/1367)) ([a46db0f](https://togithub.com/googleapis/java-spanner-jdbc/commit/a46db0f7651b9faab12e726893b60c9392130218))


### Documentation

* Add sample for Spring Data MyBatis ([googleapis#1352](https://togithub.com/googleapis/java-spanner-jdbc/issues/1352)) ([9797203](https://togithub.com/googleapis/java-spanner-jdbc/commit/9797203a3708951ed394fa9b6979578db2fc01a2))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants