Skip to content

feat: API regeneration: release-2026-04-06.08-02-47#3146

Merged
jskeet merged 58 commits intomainfrom
release-2026-04-06.08-02-47
Apr 6, 2026
Merged

feat: API regeneration: release-2026-04-06.08-02-47#3146
jskeet merged 58 commits intomainfrom
release-2026-04-06.08-02-47

Conversation

@amanda-tarafa
Copy link
Copy Markdown
Contributor

Changes in this PR will be published to Nuget on the next release cycle.

@amanda-tarafa amanda-tarafa requested a review from a team as a code owner April 6, 2026 08:09
@jskeet jskeet merged commit a97ae16 into main Apr 6, 2026
6 checks passed
@jskeet jskeet deleted the release-2026-04-06.08-02-47 branch April 6, 2026 08:11
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request involves extensive updates across numerous Google Cloud service discovery documents, including AlloyDB, Analytics Admin, Bigtable, Dataplex, and Redis. Key changes include the addition of new resources like Endpoint and MemoryLayer, new fields for configuration (e.g., isHotStandby, allPorts, guestFlush), and updated documentation for location listing methods. Feedback was provided regarding the removal of readOnly attributes from resource name fields in the Analytics Admin API, which could impact client library generation, and a suggestion was made to replace a placeholder description in the Backup DR API with more descriptive text.

Comment on lines 5507 to 5510
"name": {
"description": "Output only. Resource name of this account. Format: accounts/{account} Example: \"accounts/100\"",
"readOnly": true,
"description": "Identifier. Resource name of this account. Format: accounts/{account} Example: \"accounts/100\"",
"type": "string"
},
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The readOnly: true attribute has been removed from this resource name field. While the description has been updated to "Identifier", removing readOnly can be misleading as resource names are typically immutable after creation. If this field cannot be modified via a PATCH request, it should be marked as readOnly: true to provide a clear signal to client library generators and developers. This comment applies to similar changes for other resource name fields in this file.

"type": "object"
},
"ComputeInstanceBackupPlanProperties": {
"description": "--- ComputeInstanceBackupPlanProperties Message ---",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The description for ComputeInstanceBackupPlanProperties appears to be a placeholder. A more descriptive summary would be helpful for users of the API. For example: "Properties for a Compute Engine instance backup plan."

Suggested change
"description": "--- ComputeInstanceBackupPlanProperties Message ---",
"description": "Properties for a Compute Engine instance backup plan.",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants