[TR] A11y: Accessible names: the focus with the button name is not shown for filtering and sorting options on the Report page#1467
Merged
Conversation
hitnik
approved these changes
Mar 12, 2026
sofyakurilova
added a commit
that referenced
this pull request
Mar 17, 2026
* [TR] A11y: Clear purpose: The link"here" is used on the Welcome modal (#1455) * Improve "here" link * Adds tooltip to delete certificate (#1456) Signed-off-by: Sofia Kurilova <kurilova@google.com> * Adds tooltip to clear search button (#1457) Signed-off-by: Sofia Kurilova <kurilova@google.com> * Fix a11y issues: (#1458) - modal label; - device aria-label; - firmware rendering logic; * [TR] A11y: Screen reader: some UI elements are not announced by screen reader (#1462) * Adds timeout to focus element to pronounce title on navigation * Adds improvements for better a11y (#1463) * Adds improvements for better a11y; return focus on previous element when the modal is closed (#1464) * Focus input after search is cleared (#1466) * [TR] A11y: Accessible names: the focus with the button name is not shown for filtering and sorting options on the Report page (#1467) * Adds tooltip for sorting and filtering * Adds header tooltip (#1469) * [TR] A11y: Focus: the focus is moved to the first interactive element in the content instead of moving back to the initial button (#1470) * Fix focus after closing the modal * Update version * [TR] A11y: Focus: the Download options are not focused with help of Tab key or arrows (#1443) * Adds arrow navigation * Adds tests --------- Signed-off-by: Sofia Kurilova <kurilova@google.com> * [TR] A11y: The focus is not visible for the saved draft of the risk profile (#1444) * Focus newly saved profile --------- Signed-off-by: Sofia Kurilova <kurilova@google.com>
sofyakurilova
added a commit
that referenced
this pull request
Mar 24, 2026
* [TR] A11y: Clear purpose: The link"here" is used on the Welcome modal (#1455) * Improve "here" link * Adds tooltip to delete certificate (#1456) * Adds tooltip to clear search button (#1457) * Fix a11y issues: (#1458) - modal label; - device aria-label; - firmware rendering logic; * [TR] A11y: Screen reader: some UI elements are not announced by screen reader (#1462) * Adds timeout to focus element to pronounce title on navigation * Adds improvements for better a11y (#1463) * Adds improvements for better a11y; return focus on previous element when the modal is closed (#1464) * Focus input after search is cleared (#1466) * [TR] A11y: Accessible names: the focus with the button name is not shown for filtering and sorting options on the Report page (#1467) * Adds tooltip for sorting and filtering * Adds header tooltip (#1469) * [TR] A11y: Focus: the focus is moved to the first interactive element in the content instead of moving back to the initial button (#1470) * Fix focus after closing the modal * Update version * [TR] A11y: Focus: the Download options are not focused with help of Tab key or arrows (#1443) * Adds arrow navigation * Adds tests --------- * [TR] A11y: The focus is not visible for the saved draft of the risk profile (#1444) * Focus newly saved profile --------- Signed-off-by: Sofia Kurilova <kurilova@google.com>
sofyakurilova
added a commit
that referenced
this pull request
Jun 25, 2026
* [TR] A11y: The focus is not visible for the saved draft of the risk profile (#1444) * Focus newly saved profile * [TR] The description of the "steps to resolve" is not aligned in case of long text (#1445) * Fix css --------- Signed-off-by: Sofia Kurilova <kurilova@google.com> * [TR] A11y: Focus: the Download options are not focused with help of Tab key or arrows (#1443) * Adds arrow navigation * Adds tests --------- Signed-off-by: Sofia Kurilova <kurilova@google.com> * Fix TLS 1.0 dublicated details. (#1447) * get only unique values for TLS 1.0 details --------- Co-authored-by: Aliaksandr Nikitsin <aliaksandrn@google.com> * bacnet server settings * add type field to certificates * mocks * [TR] The Steps to resolve text is not available for some Non-Compliant tests on the Connection module (#1449) * Adds missing steps to resolve * [TR][FE] Display the certificate type as a separate column in the list-view (#1451) * Adds certificate type * update python deps * cffi * pyopenssl * steps to resolve * test details * pylint * quotes * remove duplicated message * unit tests * BAC0 version * refctor protocol bacnet * refactor core protocol module to handle async BAC0 * pylint * unit tests * improve non-compliant vm * improve connection module non-compliant * add bacnet test description to docs * Merge release 2.3.3 into main (#1476) (#1488) * [TR] A11y: Clear purpose: The link"here" is used on the Welcome modal (#1455) * Improve "here" link * Adds tooltip to delete certificate (#1456) * Adds tooltip to clear search button (#1457) * Fix a11y issues: (#1458) - modal label; - device aria-label; - firmware rendering logic; * [TR] A11y: Screen reader: some UI elements are not announced by screen reader (#1462) * Adds timeout to focus element to pronounce title on navigation * Adds improvements for better a11y (#1463) * Adds improvements for better a11y; return focus on previous element when the modal is closed (#1464) * Focus input after search is cleared (#1466) * [TR] A11y: Accessible names: the focus with the button name is not shown for filtering and sorting options on the Report page (#1467) * Adds tooltip for sorting and filtering * Adds header tooltip (#1469) * [TR] A11y: Focus: the focus is moved to the first interactive element in the content instead of moving back to the initial button (#1470) * Fix focus after closing the modal * Update version * [TR] A11y: Focus: the Download options are not focused with help of Tab key or arrows (#1443) * Adds arrow navigation * Adds tests --------- * [TR] A11y: The focus is not visible for the saved draft of the risk profile (#1444) * Focus newly saved profile --------- Signed-off-by: Sofia Kurilova <kurilova@google.com> * remove port from get_ciphers * tls 1.3 ciphers validation * configure non-compliant vm for TLS 1.3 * pylint * fix dst_ip * Send message into mqtt about the new device conntected (#1495) * Display message from info (#1494) * docs * update vagrant image * add reports folder to the install script * add reports to device * copy old reports to a new folder * change device save order * save report when a test complited to a common folder * pdf report and export endpoint * delete report endpoint * reports list endpoint * delete device * fix reports list * mocks * test api * pylint * test api * test script * system status mocks * Change mocks (#1502) * Change report endpoints (#1503) * remove ntp list * aiohttp and ntplib * ntp whitelist refactor * [TR] Actions for the historical report data don't work (#1505) * Fix report endpoints * update version * The message about unexpected device connected doesn' t appear (#1506) * Join log messages for mqtt * Update version * [Testrun] Github: Change TLS tests description text (#1507) * Improve error message * Update version --------- Signed-off-by: Sofia Kurilova <kurilova@google.com> * [Testrun] updated preliminary questions - risk profile - Welcome Pop-up (#1508) * Update text * Update version * Revert "[Testrun] Github: Change TLS tests description text (#1507)" (#1509) * Revert "[Testrun] Github: Change TLS tests description text (#1507)" This reverts commit a6dd262. Signed-off-by: Sofia Kurilova <kurilova@google.com> * Update the json; mark device Invalid if the required additional information is missing (#1513) Signed-off-by: Sofia Kurilova <kurilova@google.com> * outbount tls connections versions detection * remove TLS 1.0 from compliant virtual device * compliant vm * improve get hello packets script * invalid vm device * tls 1.0 new implementation * TLS 1.0 documentation * unit tests * Update mockoon.json (#1515) * fix chromium installation * ui test * chromium no-sandbox * add hmtl5lib and update other deps * connection module deps * update tls module deps * remove obsolete load reports method * [Testrun] : Risk Assessment new updated questions - Backend (#1526) * Update risk profile * Update version * Fix tests * Revert risk assessment changes (#1527) * Revert "[Testrun] updated preliminary questions - risk profile - Welcome Pop-up (#1508)" This reverts commit 9a17979 * Revert "Update the json; mark device Invalid if the required additional information is missing (#1513)" This reverts commit 90b4597 * Revert "Update mockoon.json (#1515)" This reverts commit 2c6950d. * Revert "[Testrun] : Risk Assessment new updated questions - Backend (#1526)" This reverts commit a7761f8. * Revert "Update the json; mark device Invalid if the required additional information is missing (#1513)" This reverts commit 90b4597 * [Testrun] Github: Change TLS tests description text (#1534) * Fix url for report deletion (#1536) * Fix url for report deletion * Fix tests * Update version * device with report model * find report new approach * change test folder path * change reports search approach * pylint * api tests * edit reports before get list of reports * update json report * Update version * bacnet protocol version async * handle bacnet async calls * report device deep copy * update actions/ checkout to v6.0.3 * update upload-artifact action to v7.0.1 * update upload artifact github actions to v8.0.1 * update scorecard version to 2.4.3 * codeql upload update to 4.36.2 * setup-node actions update to v6.4.0 --------- Signed-off-by: Sofia Kurilova <kurilova@google.com> Co-authored-by: Aliaksandr Nikitsin <aliaksandrn@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tooltip for sorting and filtering