Skip to content

Fix missing dns.pcap #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jboddey merged 1 commit into from
Feb 28, 2025
Merged

Fix missing dns.pcap #1166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions modules/test/dns/python/src/dns_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
"""DNS test module"""
import subprocess
from scapy.all import rdpcap, DNS, IP, Ether, DNSRR
from scapy.error import Scapy_Exception
from test_module import TestModule
import os
from collections import Counter
Expand Down Expand Up @@ -156,9 +157,15 @@ def generate_module_report(self):
def extract_dns_data(self):
dns_data = []

# Read the pcap file
packets = rdpcap(self.dns_server_capture_file) + rdpcap(
self.startup_capture_file) + rdpcap(self.monitor_capture_file)
# Read the startup and monitor pcap files
packets = (rdpcap(self.startup_capture_file) +
rdpcap(self.monitor_capture_file))

# Read the dns.pcap file
try:
packets += rdpcap(self.dns_server_capture_file)
except (FileNotFoundError, Scapy_Exception):
LOGGER.error('dns.pcap not found or empty, ignoring')

# Iterate through DNS packets
for packet in packets:
Expand Down