Conversation
|
Thanks! It looks like pytype/tools/analyze_project/pytype_runner_test.py needs to be updated. |
|
Actually, there's one more place in pytype that probably needs to be changed: https://github.com/google/pytype/blob/master/pytype/tools/analyze_project/main.py#L77. If I think something like the following would work: |
|
@rchen152 Thanks for all your inputs, I guess it should work now. |
|
Thanks for sending the additional PR. For this one, the failing test still needs to be updated. It looks like the broken test cases are TestYieldSortedModules.test_non_py_dep and TestGetModuleAction.test_skip in pytype/tools/analyze_project/pytype_runner_test.py. Since they're testing behavior that this change is removing, I think you can just delete them. |
|
Could you copy the changes from #207 into this PR instead? It's better to have the test removal done together with the motivating change; also, if they're submitted separately, I think you'd have to rebase this PR on top of the master branch. |
|
@rchen152 Sure, I will. |
|
@rchen152 It's done. |
rchen152
left a comment
There was a problem hiding this comment.
Thanks, looks good. Again, please don't merge this PR; it'll be closed automatically once this change is imported and re-exported.
|
@rchen152 Sure, Thanks!! |
|
@rchen152 Thanks!! |
Part of #111