This repository was archived by the owner on Aug 29, 2024. It is now read-only.
Better lone parenthesis handling#250
Merged
evykassirer merged 1 commit intogoogle:masterfrom Apr 9, 2020
Merged
Conversation
evykassirer
approved these changes
Apr 9, 2020
Contributor
evykassirer
left a comment
evykassirer
left a comment
There was a problem hiding this comment.
thanks so much for this!
I haven't been maintaining this project for a few years, and don't know if I hold enough context at this point to feel confident approving your PR
... but it's so short and looks so likely to be mergeable without problems so... ship it :) 🚢
thanks for adding your test cases!
Contributor
|
I really don't remember how anything is set up - are you able to merge it as the one who opened the PR, or do I need to do it? ^^' |
Contributor
Author
|
@evykassirer thanks for the quick review!! And only those with write-access to the project can merge, so unfortunately I can't merge this myself. |
Contributor
|
Yes, that makes sense! Thanks :) |
Contributor
Author
|
@evykassirer awesome, thanks! Does the version still need to be bumped / the update published to npm? |
evykassirer
added a commit
that referenced
this pull request
May 23, 2020
This reverts commit d65a386.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#249
Hi there! This is my first contribution to mathsteps, so apologies if this is not a very robust solution; happy to investigate further.