Update ListCheckRunsOptions with new field AppID#2236
Update ListCheckRunsOptions with new field AppID#2236gmlewis merged 4 commits intogoogle:masterfrom rojanDinc:fix/2231/update-list-check-runs-options
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2236 +/- ##
==========================================
+ Coverage 97.79% 97.80% +0.01%
==========================================
Files 113 113
Lines 10156 10205 +49
==========================================
+ Hits 9932 9981 +49
Misses 156 156
Partials 68 68
Continue to review full report at Codecov.
|
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @rojanDinc!
Just one change, please, then we should be ready for a second LGTM before merging.
Note that any other contributor to this repo is welcome to provide the second LGTM/approval after reviewing.
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @rojanDinc !
LGTM.
Merging after tests pass.
|
It looks like the tests failed. Please make sure to run |
|
Hi, I forgot to run tests locally once I changed |
github/checks.go
Outdated
| CheckName *string `url:"check_name,omitempty"` // Returns check runs with the specified name. | ||
| Status *string `url:"status,omitempty"` // Returns check runs with the specified status. Can be one of "queued", "in_progress", or "completed". | ||
| Filter *string `url:"filter,omitempty"` // Filters check runs by their completed_at timestamp. Can be one of "latest" (returning the most recent check runs) or "all". Default: "latest" | ||
| AppID *int64 `url:"app_id,omitempty"` // Filters check runs by GitHub App ID. |
There was a problem hiding this comment.
Please run gofmt on this file and push the changes.
There was a problem hiding this comment.
My bad. I've formatted the code hopefully everything is in place now.
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @rojanDinc !
LGTM.
Merging.
2 participants
#2231