Fix secondary rate limits URL and improve related documentation#2229
Merged
gmlewis merged 1 commit intogoogle:masterfrom Dec 16, 2021
Merged
Fix secondary rate limits URL and improve related documentation#2229gmlewis merged 1 commit intogoogle:masterfrom
gmlewis merged 1 commit intogoogle:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2229 +/- ##
=======================================
Coverage 97.81% 97.81%
=======================================
Files 112 112
Lines 10117 10117
=======================================
Hits 9896 9896
Misses 154 154
Partials 67 67
Continue to review full report at Codecov.
|
gmlewis
approved these changes
Dec 15, 2021
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @rpelliard !
LGTM.
Awaiting second LGTM before merging.
Any other repo contributor can approve for the second LGTM.
pierce-m
approved these changes
Dec 16, 2021
Collaborator
|
Thank you, @pierce-m ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like GitHub is now designating "abuse rate limits" as "secondary rate limits": https://docs.github.com/en/rest/overview/resources-in-the-rest-api#secondary-rate-limits
The URL returned in the error response also changed, so this PR updates it so that these errors can properly be caught again.
This PR also includes a suggestion to update the main documentation page to mention this error type, to make it more discoverable.