Update GitHub Pages API to add new response parameters#2109
Merged
gmlewis merged 10 commits intogoogle:masterfrom Dec 3, 2021
Merged
Update GitHub Pages API to add new response parameters#2109gmlewis merged 10 commits intogoogle:masterfrom
gmlewis merged 10 commits intogoogle:masterfrom
Conversation
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #2109 +/- ##
=======================================
Coverage 97.77% 97.78%
=======================================
Files 111 112 +1
Lines 9934 9956 +22
=======================================
+ Hits 9713 9735 +22
Misses 154 154
Partials 67 67
Continue to review full report at Codecov.
|
gmlewis
requested changes
Sep 28, 2021
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @rreichel3!
Just a few changes, please, and then we should be ready for a second LGTM before merging.
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
…/rreichel3/go-github into users/rreichel3/update-pages-api
gmlewis
reviewed
Sep 29, 2021
gmlewis
approved these changes
Sep 29, 2021
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @rreichel3 !
LGTM.
Awaiting second LGTM before merging.
Contributor
Author
|
👋 @wesleimp Just wanted to bump this! |
cpanato
approved these changes
Dec 3, 2021
Contributor
cpanato
left a comment
cpanato
left a comment
There was a problem hiding this comment.
lgtm
thanks for this addition
Collaborator
|
Thank you, @cpanato ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the GitHub Pages API structs to support the latest documented response from GitHub.
This fixes #2107
Its based upon the documentation on GitHub's public docs here and enables support for viewing a GitHub Pages' visibility and HTTPS configuration.