When cvd_internal_start is not invoked by cvd, forward to cvd#2733
Open
Databean wants to merge 1 commit into
Open
When cvd_internal_start is not invoked by cvd, forward to cvd#2733Databean wants to merge 1 commit into
cvd_internal_start is not invoked by cvd, forward to cvd#2733Databean wants to merge 1 commit into
Conversation
We plan to make the implementation of `cvd_internal_start` aka `launch_cvd` in the Android source tree invoke `cvd`. There is a problem with this: after the first invocation of `cvd`, it will run executable substitution in the build directory and replace the forwarding `cvd_internal_start` with the implementation in this repository. That means if we want the forward functionality to persist past one invocation, we need the `cvd_internal_start` implementation here to be forwarding as well. The forwarding is only applied when the invoking executable is not a `cvd` executable. This relies on the new flags `--reuse` and `--daemon=false` to be supported, which are in other outstanding PRs. Users calling `launch_cvd` will expect to see the behavior from these flags. Bug: b/519304405
jemoreira
approved these changes
Jun 19, 2026
Databean
changed the title
cvd_internal_start is invoked directly, invoke cvdcvd_internal_start is not invoked by cvd, forward to cvd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We plan to make the implementation of
cvd_internal_startakalaunch_cvdin the Android source tree invokecvd. There is a problem with this: after the first invocation ofcvd, it will run executable substitution in the build directory and replace the forwardingcvd_internal_startwith the implementation in this repository.That means if we want the forward functionality to persist past one invocation, we need the
cvd_internal_startimplementation here to be forwarding as well. The forwarding is only applied when the invoking executable is not acvdexecutable.This relies on the new flags
--reuseand--daemon=falseto be supported, which are in other outstanding PRs. Users callinglaunch_cvdwill expect to see the behavior from these flags.Bug: b/519304405