Skip to content

Conversation

@wyf7107
Copy link
Collaborator

@wyf7107 wyf7107 commented Feb 11, 2026

Please ensure you have read the contribution guide before creating a pull request.

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

  • Closes: #issue_number
  • Related: #issue_number

2. Or, if no issue exists, describe the change:

If applicable, please follow the issue templates to provide as much detail as
possible.

Problem:
A clear and concise description of what the problem is.

Solution:
A clear and concise description of what you want to happen and why you choose
this solution.

Testing Plan

Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.

Unit Tests:

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.

Please include a summary of passed pytest results.

Manual End-to-End (E2E) Tests:

Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

Additional context

Add any other context or screenshots about the feature request here.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @wyf7107, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the ADK Python library to version 1.25.0, incorporating a comprehensive set of new features, critical bug fixes, and general improvements. The changes enhance core functionalities, expand AI model capabilities, refine development tools, and improve web server stability and diagnostics, aiming to deliver a more robust and feature-rich platform.

Highlights

  • Core Features: Added a demo for the simple prompt optimizer, a --auto_create_session flag to the adk api_server CLI, an add_events_to_memory facade for event-delta, post-invocation token-threshold compaction with event retention, and report generation to the adk conformance test command.
  • Model Enhancements: Introduced a base_url option to the Gemini LLM class.
  • Tooling Improvements: Enhanced Google credentials config to support externally passed access tokens, updated the agent simulator with improved prompts and environment data, added a tool to load MCP resources, and integrated SkillToolset into ADK.
  • Web Server Functionality: Added /health and /version endpoints to the ADK web server.
  • Bug Fixes: Resolved issues including async iteration for VertexAiSessionService pagination, an event loop closed bug in McpSessionManager, preservation of thought_signature in function call conversions, propagation of grounding and citation metadata in streaming responses, added endpoints for artifact version metadata, supported escaped curly braces in instruction templates, stripped timezone for PostgreSQL timestamps, handled None prompt tokens in streaming mode, passed invocation_id from /run to Runner.run_async, conditionally preserved function call IDs in LLM requests, migrated VertexAiMemoryBankService to use the async Vertex AI client, handled list values in Gemini schema sanitization, and switched to using a logger instead of print in MCP.
  • General Improvements: Replaced instance checks for LlmAgent with hasAttribute checks and improved logging of exception details before re-raising in MCP session execution.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • CHANGELOG.md
    • Added detailed release notes for version 1.25.0, including new features, bug fixes, and improvements.
Activity
  • No specific review comments or activity recorded in the provided context.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@adk-bot adk-bot added the core [Component] This issue is related to the core interface and implementation label Feb 11, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request prepares for the v1.25.0 release by updating the version in src/google/adk/version.py and adding a comprehensive list of new features, bug fixes, and improvements to CHANGELOG.md. The changes look good overall. I've added a couple of minor suggestions to improve the wording of some entries in the changelog for better readability.

* Conditionally preserve function call IDs in LLM requests ([663cb75](https://github.com/google/adk-python/commit/663cb75b3288d8d0649412e1009329502b21cbbc))
* Migrate VertexAiMemoryBankService to use the async Vertex AI client ([64a44c2](https://github.com/google/adk-python/commit/64a44c28974de77cf8934f9c3d1bc03691b90e7b))
* Handle list values in Gemini schema sanitization ([fd8a9e3](https://github.com/google/adk-python/commit/fd8a9e3962cca4f422beb7316cbe732edf726d51))
* Used logger to log instead of print in MCP ([6bc70a6](https://github.com/google/adk-python/commit/6bc70a6bab79b679a4b18ad146b3450fb9014475))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For clarity and better grammar, consider rephrasing this changelog entry. For example: 'Replaced print with logger for logging in MCP'.

Suggested change
* Used logger to log instead of print in MCP ([6bc70a6](https://github.com/google/adk-python/commit/6bc70a6bab79b679a4b18ad146b3450fb9014475))
* Replaced `print` with logger for logging in MCP ([6bc70a6](https://github.com/google/adk-python/commit/6bc70a6bab79b679a4b18ad146b3450fb9014475))


### Improvements

* Replace check of instance for LlmAgent with hasAttribute check ([7110336](https://github.com/google/adk-python/commit/7110336788662abb8c9bbbb0a53a50cc09130d5e))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve clarity and technical precision, consider rephrasing this entry. Using backticks for code elements like isinstance and hasattr would also improve readability.

Suggested change
* Replace check of instance for LlmAgent with hasAttribute check ([7110336](https://github.com/google/adk-python/commit/7110336788662abb8c9bbbb0a53a50cc09130d5e))
* Replace `isinstance` check for `LlmAgent` with `hasattr` check ([7110336](https://github.com/google/adk-python/commit/7110336788662abb8c9bbbb0a53a50cc09130d5e))

@wuliang229 wuliang229 closed this Feb 12, 2026
@Jacksunwei Jacksunwei deleted the v1.25.0 branch February 12, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core [Component] This issue is related to the core interface and implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants