fix(config): migrate coreTools setting to tools.core#27947
Conversation
Updates GitHub workflows and a2a-server configuration to use the nested `tools.core` schema instead of the deprecated `coreTools` array.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request completes the transition from the legacy 'coreTools' configuration property to the standardized 'tools.core' nested schema. By updating both the A2A server configuration logic and various automated GitHub Action workflows, this change ensures consistency across the codebase and prevents potential schema validation errors. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
📊 PR Size: size/M
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates the configuration settings in a2a-server by removing the deprecated coreTools property from the Settings interface and config.ts in favor of the nested tools.core structure, updating the test suite accordingly. The reviewer notes that there are still references to settings.coreTools in the codebase that will cause TypeScript compilation errors and should be removed. Additionally, an assertion in settings.test.ts needs to be updated to align with the new nested configuration format.
| // similar to how packages/cli/src/config/settings.ts handles it. | ||
| export interface Settings { | ||
| mcpServers?: Record<string, MCPServerConfig>; | ||
| coreTools?: string[]; |
There was a problem hiding this comment.
Removing coreTools from the Settings interface is correct as part of the migration, but there are still references to settings.coreTools in the codebase that will now cause TypeScript compilation errors. Instead of maintaining backward compatibility for deprecated configuration settings, we should remove them and their associated logic entirely to avoid confusion.
References
- Instead of maintaining backward compatibility for deprecated or unshipped configuration settings, remove them and their associated logic entirely to avoid confusion.
| showMemoryUsage: true, | ||
| coreTools: ['tool1', 'tool2'], | ||
| tools: { | ||
| core: ['tool1', 'tool2'], |
There was a problem hiding this comment.
Since settings.tools.core is now used instead of coreTools, the assertion on line 114 of this file should be updated to use the new nested configuration format. This aligns with removing backward compatibility logic for deprecated settings.
References
- Instead of maintaining backward compatibility for deprecated or unshipped configuration settings, remove them and their associated logic entirely to avoid confusion.
gemini-cli
Bot
added
the
status/need-issue
|
Please fix failing tests, otherwise LGTM and to the CLI's review. CLI's thoughts: Detailed FindingsBelow is the detailed analysis of the issues found during verification. 1. Critical compilation error in
|
DavidAPierce
left a comment
DavidAPierce
left a comment
There was a problem hiding this comment.
approved pending comment(s) resolution.
|
Size Change: -4 B (0%) Total Size: 33.9 MB
ℹ️ View Unchanged
|
3 participants
Summary
Migrates the
coreToolsarray setting to the nestedtools: { core: [] }schema format across GitHub Actions workflows and the A2A server configuration.Details
The codebase has transitioned from the deprecated
coreToolsproperty to the newtools.corenested structure. While most of the application was updated, several scheduled/automated GitHub Action workflows and the A2A server configuration were still referencing the oldcoreToolssetting.This PR updates those residual configurations to ensure consistency and prevent schema validation errors.
Files updated:
.github/workflows/community-report.yml.github/workflows/gemini-automated-issue-dedup.yml.github/workflows/gemini-automated-issue-triage.yml.github/workflows/gemini-scheduled-issue-dedup.yml.github/workflows/gemini-scheduled-issue-triage.ymlpackages/a2a-server/src/config/config.tspackages/a2a-server/src/config/settings.test.tspackages/a2a-server/src/config/settings.tsRelated Issues
None.
How to Validate
settingspayload now usestools: { core: [...] }.Settingsno longer containscoreTools.npm run test --workspaces).Pre-Merge Checklist