Implement register unexposed classes#970
Merged
dsnopek merged 1 commit intoSep 11, 2023
Merged
Conversation
Daylily-Zeleen
marked this pull request as ready for review
December 20, 2022 03:23
This was referenced Dec 20, 2022
Daylily-Zeleen
force-pushed
the
daylily-zeleen/register_unexposed_class
branch
from
December 20, 2022 08:17
e76f7cf to
939e6db
Compare
Geometror
added
enhancement
79 tasks
Daylily-Zeleen
force-pushed
the
daylily-zeleen/register_unexposed_class
branch
2 times, most recently
from
July 17, 2023 10:29
d1693b1 to
bf59f01
Compare
Daylily-Zeleen
force-pushed
the
daylily-zeleen/register_unexposed_class
branch
from
September 3, 2023 06:02
bf59f01 to
21ed03b
Compare
Daylily-Zeleen
force-pushed
the
daylily-zeleen/register_unexposed_class
branch
from
September 3, 2023 17:00
21ed03b to
2d1f852
Compare
dsnopek
approved these changes
Sep 3, 2023
dsnopek
left a comment
dsnopek
left a comment
Collaborator
There was a problem hiding this comment.
Thanks!
As I mentioned over on PR godotengine/godot#70329, I tested this and it's working great for me!
The code looks good as well.
Collaborator
|
Godot PR was just merged! So, merging this one as well :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of renaming gdnative to gdextension, I need to remake #951. Otherwise I can't keep 1 commit.
Need #70329.