Fix namespace isolation in GDCLASS macro#920
Merged
akien-mga merged 1 commit intoNov 11, 2022
Merged
Conversation
Member
|
I think it's better if the example uses But indeed, we should probably consider separating the CI testing environment from the end user demo project. The current project was meant more for testing but ended up being used as reference demo. |
touilleMan
force-pushed
the
fix-using-godot-required
branch
from
November 11, 2022 16:26
85f85ed to
2745d34
Compare
Member
Author
|
@akien-mga I've removed the second commit then 👍 |
akien-mga
approved these changes
Nov 11, 2022
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #918
Note the second commit in this PR modify the test to remove the use of
using namespace godot;, from my point of view this has both pros and cons:D_METHODwhich looks like a macro but is in fact a method (hence theGDCLASS(...)vsgodot::D_METHOD(...))So what do you think ?
I guess the best of both worlds would be to have two separates folders: one for example and another for test (the latter typically being also run in the CI, which is something not currently done). However I'm personally too lazy for this change 😄