[DRAFT] Make memnew(RefCounted) return Ref<T> for improved ownership safety#1973
Draft
dsnopek wants to merge 2 commits intogodotengine:masterfrom
Draft
[DRAFT] Make memnew(RefCounted) return Ref<T> for improved ownership safety#1973dsnopek wants to merge 2 commits intogodotengine:masterfrom
memnew(RefCounted) return Ref<T> for improved ownership safety#1973dsnopek wants to merge 2 commits intogodotengine:masterfrom
Conversation
dsnopek
added
the
enhancement
dsnopek
force-pushed
the
memnew-refcounted
branch
from
efd701f to
4c3c568
Compare
dsnopek
changed the title
memnew(RefCounted) return Ref<T> for improved ownership safetymemnew(RefCounted) return Ref<T> for improved ownership safety
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attempts to implement support for godotengine/godot#118214
It depends on #1972
Currently marked as DRAFT because of the PR dependency, but also this needs more testing, and ideally, a few new unit tests