Update missing hashfuncs#1858
Conversation
dsnopek
left a comment
dsnopek
left a comment
There was a problem hiding this comment.
Thanks! I compared the changes to the code in Godot, and it looks like it matches to me. I have only the one note below
| #include <intrin.h> | ||
| #endif | ||
|
|
||
| #include "godot_cpp/templates/pair.hpp" |
There was a problem hiding this comment.
This should using #include <...> like the others here, and be ordered alphabetically
There was a problem hiding this comment.
Fixed and pushed that.
I do realize it probably makes no difference at all but is there a reason godot-cpp uses #include <...> for including godot-cpp files? Typically #include <...> is only used for system includes and that is how it is used upstream too so it's always seemed odd to me that godot-cpp does it like this.
There was a problem hiding this comment.
I'm not sure - I don't recall ever having discussed it, but it's used consistently. If we decided we wanted to change this, we should change it everywhere. I think the consistency is more important than which include style we use
1ada0f9 to
fc70347
Compare
dsnopek
left a comment
dsnopek
left a comment
There was a problem hiding this comment.
Thanks! Looks good to me :-)
|
Cherry-picked for 4.5 in PR #1870 |
|
Cherry-picked for 4.4 in PR #1871 |
2 participants
Adds the missing hashfuncs for Color, Pair, and Callable. Mainly for the fix in godotengine/godot#107289 but I also needed the Pair hash for module compatibility.
Also updated Pair to be the same as the Pair in Godot.