Skip to content

Silenced compiler warning in godot::call_with_variant_args_ret_helper#1857

Merged
dsnopek merged 1 commit into
godotengine:masterfrom
qqwobble:silenced-warning-call-with-variant
Oct 3, 2025
Merged

Silenced compiler warning in godot::call_with_variant_args_ret_helper#1857
dsnopek merged 1 commit into
godotengine:masterfrom
qqwobble:silenced-warning-call-with-variant

Conversation

@qqwobble

@qqwobble qqwobble commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

g++ falsely flagged p_args as unused. This PR applies the same fix used in the surrounding functions.

g++ -v: g++ (Debian 12.2.0-14+deb12u1) 12.2.0

clang (using clangd) does not report this warning at all.

@qqwobble
qqwobble requested a review from a team as a code owner October 1, 2025 20:29

@Ivorforce Ivorforce left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@dsnopek

dsnopek commented Oct 3, 2025

Copy link
Copy Markdown
Collaborator

Thanks!

@dsnopek
dsnopek merged commit 28e8b1a into godotengine:master Oct 3, 2025
16 checks passed
@dsnopek dsnopek added bug This has been identified as a bug cherrypick:4.4 cherrypick:4.5 labels Oct 3, 2025
@dsnopek dsnopek added this to the 4.x milestone Oct 3, 2025
dementive pushed a commit to dementive/godot-cpp that referenced this pull request Oct 4, 2025
…ll-with-variant

Silenced compiler warning in godot::call_with_variant_args_ret_helper
@dsnopek

dsnopek commented Oct 20, 2025

Copy link
Copy Markdown
Collaborator

Cherry-picked for 4.5 in PR #1870

@dsnopek

dsnopek commented Oct 20, 2025

Copy link
Copy Markdown
Collaborator

Cherry-picked for 4.4 in PR #1871

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This has been identified as a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants