Use LocalVector instead of std::vector#1841
Merged
Merged
Conversation
This was referenced Sep 9, 2025
Ivorforce
approved these changes
Sep 11, 2025
Ivorforce
left a comment
Ivorforce
left a comment
Member
There was a problem hiding this comment.
Makes sense to me. I'm not aware of any risks / caveats of LocalVector over std::vector.
bruvzg
approved these changes
Sep 11, 2025
bruvzg
left a comment
bruvzg
left a comment
Member
There was a problem hiding this comment.
Since we have engine container templates in godot-cpp it makes sense to use them (most of the std:: usage predate addition of templates).
dsnopek
added
enhancement
dsnopek
force-pushed
the
no-std-vector
branch
from
September 16, 2025 20:48
00e25ce to
0b8e768
Compare
Collaborator
|
Thanks! |
Collaborator
|
Cherry-picked for 4.5 in PR #1870 |
Collaborator
|
Cherry-picked for 4.4 in PR #1871 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes (almost) all of the std::vector usage and replaces it with Godot's LocalVector.
There is still one place in
classes/wrapped.cppwhere std::vector is still used that I didn't want to mess with because it calls push_back during static initialization and the allocation function that LocalVector::push_back uses from the GDExtension API isn't registered yet. Reworking this to figure out a better time to call push_back didn't look too fun so I'm just going to leave it as is.I tested the build time difference with ClangBuildAnalyzer and got these results:
With these changes:
Executed in 103.10 secs
**** Time summary:
Compilation (1025 times):
Parsing (frontend): 1640.2 s
Codegen & opts (backend): 190.6 s
Without these changes
Executed in 106.30 secs
**** Time summary:
Compilation (1025 times):
Parsing (frontend): 1682.0 s
Codegen & opts (backend): 184.8 s