Test that internal classes work as expected#1818
Merged
Merged
Conversation
dsnopek
marked this pull request as draft
July 14, 2025 19:33
dsnopek
changed the title
dsnopek
force-pushed
the
test-internal-classes
branch
from
July 23, 2025 20:07
239c7cd to
309b17b
Compare
dsnopek
marked this pull request as ready for review
July 23, 2025 20:07
Ivorforce
approved these changes
Jul 23, 2025
Ivorforce
left a comment
Ivorforce
left a comment
Member
There was a problem hiding this comment.
Looks fine to me.
It would be nice if we had some way to warn people of this change when they update (ideally through the compiler). But I can't think of one. I guess they'll find out when they suddenly can't instantiate their classes anymore on test.
Collaborator
Author
We can add a note about it on the "Upgrading from Godot 4.4 to Godot 4.5" page (like the 4.3 to 4.4 one), but, yeah, folks will probably see things break first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the companion PR to godotengine/godot#108614 that also adds to the automated tests to verify that internal classes work as expected
Marking as a DRAFT because I'm not entirely sure that godotengine/godot#108614 is a good idea. :-) I'll take this out of DRAFT if that one ends up being merged