Skip to content

Replace header guards style with #pragma once#1734

Merged
dsnopek merged 3 commits into
godotengine:masterfrom
Repiteo:style/pragma-once
Mar 13, 2025
Merged

Replace header guards style with #pragma once#1734
dsnopek merged 3 commits into
godotengine:masterfrom
Repiteo:style/pragma-once

Conversation

@Repiteo

@Repiteo Repiteo commented Mar 8, 2025

Copy link
Copy Markdown
Contributor

Integrates the new #pragma once style to godot-cpp and its builders

@Repiteo Repiteo added enhancement This is an enhancement on the current functionality usability labels Mar 8, 2025
@Repiteo
Repiteo requested a review from a team as a code owner March 8, 2025 00:05
@Repiteo Repiteo changed the title Style/pragma once Replace header guards style with #pragma once Mar 8, 2025

@aaronfranke aaronfranke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me from a quick review. This is important to match godotengine/godot#102298.

@fire

fire commented Mar 10, 2025

Copy link
Copy Markdown
Member

I wasn't able to give the pull request a good look, but the feature proposal is good.

@dsnopek dsnopek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dsnopek
dsnopek merged commit d8807a1 into godotengine:master Mar 13, 2025
@dsnopek

dsnopek commented Jun 24, 2025

Copy link
Copy Markdown
Collaborator

Cherry-picked for 4.4 in PR #1805

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This is an enhancement on the current functionality usability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants