CMake: Create destination folder for doc_source.cpp generation#1709
Merged
Conversation
dsnopek
approved these changes
Feb 17, 2025
Collaborator
|
Looks good! But needs a rebase after #1707 has been merged |
When compiling using 'MinGW Makefiles' the folders aren't created automatically.
enetheru
force-pushed
the
MinGWMakefiles
branch
from
February 17, 2025 20:45
a6d212e to
23c2407
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compiling using 'MinGW Makefiles' the folders aren't created as needed.
This leads to a failure to generate an include doc_source.cpp via the python script with the error:
FileNotFoundError: [Errno 2] No such file or directory: 'C:/build/godot-cpp/build-cmake/test/src/gen/doc_data.gen.cpp'This PR will create the directory if it doesnt exist.