Skip to content

Update for virtual method compatibility system#1676

Merged
dsnopek merged 1 commit into
godotengine:masterfrom
dsnopek:gdextension-virtual-method-compat
Jan 12, 2025
Merged

Update for virtual method compatibility system#1676
dsnopek merged 1 commit into
godotengine:masterfrom
dsnopek:gdextension-virtual-method-compat

Conversation

@dsnopek

@dsnopek dsnopek commented Dec 21, 2024

Copy link
Copy Markdown
Collaborator

This implements the virtual method compatibility system from PR godotengine/godot#100674

Marking as DRAFT until that PR is merged

@dsnopek dsnopek added the enhancement This is an enhancement on the current functionality label Dec 21, 2024
@dsnopek dsnopek added this to the 4.x milestone Dec 21, 2024
@dsnopek
dsnopek requested a review from a team as a code owner December 21, 2024 00:00
@dsnopek
dsnopek marked this pull request as draft December 21, 2024 00:00
@dsnopek
dsnopek force-pushed the gdextension-virtual-method-compat branch from 573c608 to 5c9529f Compare January 11, 2025 22:37
@dsnopek dsnopek changed the title [DRAFT] Update for virtual method compatibility system Update for virtual method compatibility system Jan 11, 2025
@dsnopek
dsnopek marked this pull request as ready for review January 11, 2025 22:37
@dsnopek

dsnopek commented Jan 11, 2025

Copy link
Copy Markdown
Collaborator Author

Now that PR godotengine/godot#100674 is merged, taking this one out of draft!

@paddy-exe paddy-exe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look straightforward 👍🏻 haven't tested it though.

@dsnopek
dsnopek merged commit 65046d0 into godotengine:master Jan 12, 2025
dsnopek added a commit to dsnopek/godot-cpp that referenced this pull request Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This is an enhancement on the current functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants