CMake: Support for using build_profile.json#1670
Merged
Merged
Conversation
enetheru
force-pushed
the
build_profile
branch
2 times, most recently
from
December 11, 2024 12:22
35ca242 to
fddcb8d
Compare
enetheru
force-pushed
the
build_profile
branch
5 times, most recently
from
December 28, 2024 23:31
fb65d7b to
92696e4
Compare
enetheru
force-pushed
the
build_profile
branch
3 times, most recently
from
January 11, 2025 00:53
e716971 to
5d41a48
Compare
Add python_callouts.py to hold functions which call python utilities - generate trimmed API - generate file list - generate bindings if GODOT_BUILD_PROFILE is specified, a trimmed API file is created in the CMAKE_CURRENT_BINARY_DIR and used as the source for binding generation Simplify Code Generation Variables - use generator expressions - use math for bits - simplify if statements
enetheru
force-pushed
the
build_profile
branch
from
January 11, 2025 01:52
5d41a48 to
ae198fe
Compare
enetheru
marked this pull request as ready for review
January 11, 2025 08:17
dsnopek
approved these changes
Jan 12, 2025
dsnopek
left a comment
dsnopek
left a comment
Collaborator
There was a problem hiding this comment.
Thanks!
It worked great in my testing! I tried it with the test project via:
cmake .. -DGODOT_ENABLE_TESTING=YES -DGODOT_BUILD_PROFILE=../test/build_profile.json -G Ninja
cmake --build . --target godot-cpp.test.template_debug
The build artifacts all looked correct and the tests passed :-)
Skimming the code, that all looks good to me too. Re-organizing the python callouts into python_callouts.cmake seems like a good idea.
dsnopek
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to the CMake scripts to implement the use of build profiles.
This is upto date with the latest changes from @Faless
Changes
Add python_callouts.py to hold functions which call python utilities
if GODOT_BUILD_PROFILE is specified, a trimmed API file is created in the CMAKE_CURRENT_BINARY_DIR and used as the source for binding generation
Simplify Code Generation Variables