Update gdextension_interface.h. Add metadata to GetTypeInfo of char16_t and char32_t.#1654
Merged
dsnopek merged 1 commit intoNov 28, 2024
Merged
Conversation
dsnopek
added
the
enhancement
dsnopek
approved these changes
Nov 28, 2024
dsnopek
left a comment
dsnopek
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! Looks good to me :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if there is a standard workflow for updating, but I figured I'd go ahead and make a PR. Let me know if this is unusual or something is missing. I'm excited to get started on the variant internal accessors, so I'm making this PR first as an unopinionated update.
Let me note that i have no idea what GetTypeInfo is used for and if I'm applying the new enum cases correctly. I just went by surrounding code for context.