Directly get object instance ID from Variant and implement Variant::get_validated_object()#1591
Merged
Conversation
dsnopek
added
enhancement
dsnopek
marked this pull request as draft
September 17, 2024 15:02
This was referenced Sep 17, 2024
dsnopek
removed
the
waiting for Godot
dsnopek
marked this pull request as ready for review
October 16, 2024 14:14
Ivorforce
approved these changes
Oct 16, 2024
…::get_validated_object()`
dsnopek
force-pushed
the
variant-object-instance-id
branch
from
October 17, 2024 14:59
8879c22 to
0602c32
Compare
paddy-exe
approved these changes
Oct 29, 2024
paddy-exe
left a comment
paddy-exe
left a comment
Contributor
There was a problem hiding this comment.
Discussed at the GDExtension meeting. Changes look good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix issue #1587 after Godot PR godotengine/godot#97119 is merged (which probably means Godot 4.4+)
It allows us to safely call
Variant::operator ObjectID()even on objects that have been freed, and implementsVariant::get_validated_object()which exists in Godot itself, and is a very convenient way to check if an object is valid.Marking as a draft until PR godotengine/godot#97119 is merged