Updated all variable names to use GODOT_ prefix#1583
Merged
Conversation
changed cache type for api file and api dir to FILEPATH and PATH respectively. Minor whitespace. docstring parity
enetheru
force-pushed
the
variable-rename2
branch
from
September 13, 2024 23:36
88ea0cd to
390a9a5
Compare
enetheru
marked this pull request as ready for review
September 13, 2024 23:37
Collaborator
Author
|
Comparison Spreadsheet updated for this PR google doc |
dsnopek
approved these changes
Sep 18, 2024
dsnopek
left a comment
dsnopek
left a comment
Collaborator
There was a problem hiding this comment.
Thanks!
I tested a few of the options on Linux with the make backend, and everything seemed to be working fine :-)
This was referenced Sep 18, 2024
Collaborator
|
Cherry-picked for 4.2 in PR #1631 |
Collaborator
|
Cherry-picked for 4.3 in PR #1632 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is after the symbol-visibility fixes, to bring the existing cache variables upto the same parity as scons.
It's extremely simple, just variable renames, docstrings, minor whitespace, and variable properties to match their expected content type. ie STRING to PATH and FILEPATH for the json api files. It makes no change to the control flow.