Add missing enum & ctor for PackedVector4Array implementation#1497
Merged
dsnopek merged 1 commit intoJun 25, 2024
Merged
Conversation
akien-mga
reviewed
Jun 19, 2024
Collaborator
|
Thanks! However, this only appears to update |
Contributor
Author
Ya it does, fixed the PR. |
Naros
force-pushed
the
fix-variant-hpp-packed-vector4-array
branch
from
June 19, 2024 15:21
0167d65 to
78b6320
Compare
dsnopek
approved these changes
Jun 19, 2024
dsnopek
left a comment
dsnopek
left a comment
Collaborator
There was a problem hiding this comment.
Thanks!
I haven't tested it, but the code looks good to me. Assuming this passes CI, I think it's good to go :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dsnopek I think this may have been overlooked in #1456