Allow selecting Godot version to run the tests with#1493
Merged
Conversation
dsnopek
added
enhancement
AThousandShips
approved these changes
Jun 14, 2024
AThousandShips
left a comment
AThousandShips
left a comment
Member
There was a problem hiding this comment.
Haven't tested but the code looks right and useful
dsnopek
marked this pull request as draft
June 14, 2024 16:26
dsnopek
marked this pull request as ready for review
June 14, 2024 16:40
dsnopek
changed the title
Collaborator
Author
|
Taking this out of draft because this PR and the 4.2 version are working! I'm really surprised this worked on my first try - I was expecting to have to tweak it and push a bunch of times before they both passed, but I guess I got lucky today :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow selecting the Godot version to run the tests with on CI.